Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6983 closed defect (fixed)

crash cause it a IRC DCC file transfer

Reported by: harrykar Owned by:
Priority: normal Milestone: 0.15
Component: None Version:
Severity: normal Keywords:
Cc: Blocked By:
Blocking: OS: All

Description

Bug description

A programming error has been detected. It probably is not fatal, but should be reported to the developers nonetheless.

A friend send me a file(he has xchat 2.8.6) in a IRC channel and i get the crash TIA

Steps to reproduce

Software versions

OS version: Ubuntu 10.04LTS Gajim version: 0.14.4 GTK version: 2.20.1 PyGTK version: 2.17.0

Attachments (1)

Screenshot-1.png (240.1 KB) - added by harrykar 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by harrykar

comment:1 Changed 5 years ago by asterix

Could you open XML console (actions -> advanced) then ask your contact to send you a file and show us what is printed in XML console at this moment?

comment:2 in reply to: ↑ description Changed 5 years ago by harrykar

Replying to harrykar:

Bug description

A programming error has been detected. It probably is not fatal, but should be reported to the developers nonetheless.

A friend send me a file(he has xchat 2.8.6) in a IRC channel and i get the crash TIA

Traceback = (most recent call last):

File "/usr/share/gajim/src/common/xmpp/idlequeue.py", line 533, in _process_events

return IdleQueue?._process_events(self, fd, flags)

File "/usr/share/gajim/src/common/xmpp/idlequeue.py", line 394, in _process_events

obj.pollin()

File "/usr/share/gajim/src/common/xmpp/transports_nb.py", line 414, in pollin

self._do_receive()

File "/usr/share/gajim/src/common/xmpp/transports_nb.py", line 600, in _do_receive

self._on_receive(received)

File "/usr/share/gajim/src/common/xmpp/transports_nb.py", line 614, in _on_receive

self.on_receive(data)

File "/usr/share/gajim/src/common/xmpp/dispatcher_nb.py", line 452, in dispatch

handlerfunc?(session, stanza)

File "/usr/share/gajim/src/common/protocol/bytestream.py", line 544, in _bytestreamSetCB

self.send_success_connect_reply, self._connect_error)

File "/usr/share/gajim/src/common/socks5.py", line 124, in connect_to_hosts

receiver = Socks5Receiver(self.idlequeue, streamhost, sid, file_props)

File "/usr/share/gajim/src/common/socks5.py", line 952, in init

Socks5.init(self, idlequeue, streamhosthost?,

KeyError?: 'host'

Steps to reproduce

Try to receive a file trough IRC DCC

IRC transport:irc.einfachjabber.de

comment:3 Changed 5 years ago by asterix

Thanks, but could you get XML logs?

comment:4 Changed 5 years ago by harrykar

xml stanzas

cause problem with capchas here i past in http://pastebin.com/Bw6s6ai5

comment:5 Changed 5 years ago by asterix

Perfect, that's what I thought. The other client send you this:

<streamhost jid='irc.einfachjabber.de' port='0'/>

which is invalid. There MUST be a 'host' attribute. You can report that to your contact's client.

Patch will arrive this evening when I'll go back home.

Thanks

comment:6 Changed 5 years ago by Yann Leboulanger <asterix@…>

  • Milestone set to 0.15
  • Resolution set to fixed
  • Status changed from new to closed

(In [17c64d4acdb8]) don't crash when we get wrong streamhost. Fixes #6983

comment:7 Changed 5 years ago by Yann Leboulanger <asterix@…>

(In [c1caeb5e8e24]) don't crash when we get wrong streamhost. Fixes #6983

Note: See TracTickets for help on using tickets.