Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#5564 closed defect (fixed)

getting errors when trying to watch history

Reported by: chatte Owned by:
Priority: normal Milestone: 0.13.3
Component: history Version: 0.13.1
Severity: minor Keywords:
Cc: v.chatte.noire@… Blocked By:
Blocking: OS: Unix

Description

Bug description

I get this programming errors when i'm trying to read my history with someone: Traceback (most recent call last):

File "/usr/share/gajim/src/message_window.py", line 346, in accel_group_func

control._on_history_menuitem_activate()

File "/usr/share/gajim/src/chat_control.py", line 903, in _on_history_menuitem_activate

gajim.interface.instanceslogs?.open_history(jid, self.account)

File "/usr/share/gajim/src/history_window.py", line 613, in open_history

self._load_history(jid, account)

File "/usr/share/gajim/src/history_window.py", line 253, in _load_history

info_jid, info_account, info_name, info_completion = self.completion_dict[jid_or_name]

TypeError?: 'NoneType?' object is not iterable

It's quite annoying but still i can read history when i close windows with these errors

Traceback (most recent call last):

File "/usr/share/gajim/src/history_window.py", line 176, in _fill_completion_dict

info_name = contact.get_shown_name()

AttributeError?: 'tuple' object has no attribute 'get_shown_name'

Steps to reproduce

"Ctrl+H" in chat with someone

Software versions

OS version: 2.6.30-2-686 GNU/Linux Sid/Squeeze?
GTK version: 2.18.3-1
PyGTK version: 2.16.0-1

Attachments (1)

history.patch (1.1 KB) - added by asterix 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by asterix

  • Milestone 0.13.2 deleted
  • Status changed from new to needinfo

Thanks for the report. I read the sources, and really see no reason for this traceback. But if you can reproduce it, you could help me debugging by adding some print here and there in the code.

Which error is printed first?

I attach a patch that adds some print when your error appear. Could you apply it and tell me what is printed when the error occurs?

Changed 7 years ago by asterix

comment:2 Changed 7 years ago by Yann Leboulanger <asterix@…>

(In [cbcb30a77ac6]) fix completion dict in history window. see #5564

comment:3 Changed 7 years ago by asterix

  • Milestone set to 0.14
  • Resolution set to fixed
  • Status changed from needinfo to closed

I applied a patch that fixed it in both trunk ([1e853e64228e]) and 0.13 branch (see previous comment)

comment:4 Changed 7 years ago by asterix

  • Milestone changed from 0.14 to 0.13.3
Note: See TracTickets for help on using tickets.