Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#5527 closed enhancement (wontfix)

MUC Dup spam

Reported by: Zash Owned by:
Priority: normal Milestone:
Component: chat Version: hg
Severity: minor Keywords:
Cc: Blocked By:
Blocking: OS: All

Description

Problem

When reconnecting (due to suspend/resume or connection drop etc), you get some duplicated lines (topic, last line someone sent).

Analysis

I find this somewhat annoying :(

Enhancement recommendation

  • Only print "User has set topic to ..." once, when creating the muc window, then only when it changes.
  • Only print lines from backlog when first creating the window, then only if you get log from when the connection was down.

Attachments (1)

dupedlinesingajim.png (66.5 KB) - added by Zash 7 years ago.
Screenshot showing duped lines

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by Zash

Screenshot showing duped lines

comment:1 Changed 6 years ago by asterix

  • Resolution set to wontfix
  • Status changed from new to closed

For topic, Gajim receives it when it connects to the room, it's not our code that "duplicates" it, we just print what we receive. We cannot print the subject when we create the room, the room is created only by the first person entering the room if it's not persistent.

For last sentense, you can configure the muc_restore_timeout value, it's the number of minutes back we request logs to server.

comment:2 Changed 6 years ago by Zash

Why are we asking for logs we already have?

comment:3 Changed 6 years ago by asterix

because when you enter the room, you may want to remember what was the topic, so having the last messages is usefull.

comment:4 Changed 6 years ago by Zash

But we already have those messages in our log-db

comment:5 Changed 6 years ago by asterix

yes and ? that doesn't change anything to ask or to look in DB. As we always need to ask server if there are new messages, it's better to to it from server than from DB

comment:6 Changed 6 years ago by Zash

What about just requesting messages since the last, see #5237

comment:7 Changed 6 years ago by asterix

read my latest comment on the ticket you link.

comment:8 Changed 6 years ago by Zash

If i set muc_restore_timeout to 1 day, disconnect from a room, and rejoin it will be like min(time()-10, time() - 86400) which will eval to time() - 86400. I really think it should be the other way around, eg max() since the numbers are in the past.

comment:9 Changed 6 years ago by asterix

default value is not 1 day but 1 hour. If I leave the room and come back half an hour later, I'm happy to see the context of the chat.

comment:10 Changed 6 years ago by Yann Leboulanger <asterix@…>

(In [f21f24d672fe]) revert wrong behaviour. see #5527

Note: See TracTickets for help on using tickets.