Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#530 closed defect (fixed)

MUC: Modifying the Ban List

Reported by: Liorithiel Owned by: asterix
Priority: normal Milestone: 0.7
Component: chat Version: 0.3
Severity: normal Keywords:
Cc: Blocked By:
Blocking: OS:

Attachments (2)

ban.diff (18.5 KB) - added by Sef 11 years ago.
update.diff (18.4 KB) - added by sef@… 11 years ago.
ok here it is, it propably has to be ironed a bit but it just works ;) good starting point as I sux in GUI programing ;)

Download all attachments as: .zip

Change History (15)

Changed 11 years ago by Sef

Changed 11 years ago by sef@…

ok here it is, it propably has to be ironed a bit but it just works ;) good starting point as I sux in GUI programing ;)

comment:1 Changed 11 years ago by asterix

  • Milestone set to 0.10
  • Status changed from new to assigned

comment:2 Changed 11 years ago by asterix

  • Resolution set to fixed
  • Status changed from assigned to closed

I improved your patch to be able to edit all affiliation lists. See [0700311882e4cb368a1810a6e33864ffc872c35f] and [7b9c45c036eb58154d36be0730a0c735b35a2d9e]

comment:3 Changed 11 years ago by nk

  • Resolution fixed deleted
  • Status changed from closed to reopened

apply button does nothing.

f.e. I cannot remove vybliz from banned jids.. I now saw SAVE button which also doesn't work

rooms for improvement:

  • propose syntax on how to do domain banning
  • allow operating on many selected rows
  • drop Save Button (we have apply button)

comment:4 Changed 11 years ago by nk

reason in banning is not exposed as column in UI

comment:5 Changed 11 years ago by asterix

We can now remove a jid from the lists

I'll add a tooltip on the add button

I don't think apply button is good cause it will send only the current displayed list. If I edit ban list (I add a jid), then switch to another list the modifications for ban list are lost. The only solution I can see to remove the save button is to 4 treeviews under the config options: one for each list (This will allow to have different treeviews to show reason for ban, nick and role for other lists).

comment:6 Changed 11 years ago by nk

tooltip on add? why not in add input text show the HIG ui. eg add jid you want to ban as primary

and as secondary Here you can write JIDS and domains to ban. The domain syntax is like balblalbalblab..

yes it's better if you have 4 treeviews and only show() the one you need at that time. then you can also remove save and leave apply do the job exactly as you said :)

comment:7 Changed 11 years ago by asterix

why not show the 4 treeviews and remove the combobox ? and maybe 5 treeviews to add the manage moderator list (which is role and not affiliation)

comment:8 Changed 11 years ago by nk

I don't know. won't that make the window too huge?

also aren't role temporary? why bother with those afterall we have right click on roster item.. I 'm just wondering here :)

comment:9 Changed 11 years ago by asterix

it won't be so huge, in general, there is not so many banned user, owner or admin.

roles are temporary indeed, so when a user leave the room, it is removed from the moderator list. And when he is in, we can remove it with right click.

comment:10 Changed 11 years ago by nk

ok don't do roles at all. about treeviews do as you wish ;)

comment:11 Changed 11 years ago by asterix

  • Resolution set to fixed
  • Status changed from reopened to closed

everything should be ok now

comment:12 Changed 11 years ago by asterix

  • Resolution fixed deleted
  • Status changed from closed to reopened

An admin is not allowed to open group chat cnofig window, but shouldbe ablt to modify the member list

comment:13 Changed 11 years ago by asterix

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.