Opened 7 years ago

Closed 6 years ago

#5040 closed enhancement (duplicate)

Improved roster search

Reported by: miracle2k Owned by:
Priority: normal Milestone:
Component: roster Version:
Severity: normal Keywords:
Cc: joti.mail@… Blocked By:
Blocking: OS: All

Description

I'd like to see the roster search improved. Rather than using the GTKs builtin features, I'd suggest to build a custom search that supports:

  • Improved search as you type, by filtering out all entries that do not match the query.
  • Searches offline contacts even if they are not currently displayed.

I'd be willing to work on this.

Change History (14)

comment:1 Changed 7 years ago by asterix

Hi, that could be indeed usefull, and maybe not too difficult to do, but when will roster become back normal? when will the filter stop hidding rows?

comment:2 Changed 7 years ago by wojtek

On ESC-press or doing some action on selected contact?

comment:3 Changed 7 years ago by asterix

hmm yes, sounds good. I wait your patch then. Don't hesitate if you have a question.

comment:4 Changed 7 years ago by wojtek

I'm not the autor of the ticket, I was just browsing track and made a suggestion on how I would see it. No I feel out of line a bit...

comment:5 Changed 7 years ago by joti

  • Cc joti.mail@… added
  • Milestone set to 0.13

Added the milestone from #5090 as this was marked as Dup. vArDo suggested the milestone.

The title is a bit unspeaking - maybe change it more telling one.

comment:6 Changed 7 years ago by asterix

  • Milestone 0.13 deleted

comment:7 Changed 6 years ago by xri://=!696F.CBD6.219E.C607

I have a basic implementation here:

http://bitbucket.org/miracle2k/gajim/changeset/cc03154d0c8b/

Some TBD notes:

  • There should be some UI indicating that filtering is active. Could be a panel at the bottom with the current filter text; even nicer would be to render the match text in bold.
  • The first contact could be auto-selected. This allows you to type a name, press ENTER and go.
  • Speaking of ENTER, this key is currently added to the filter.
  • If due to filtering a group gets hidden, it seems to be collapsed internally, and it's state not restored (though the "expanded" icon is still shown).

comment:8 Changed 6 years ago by asterix

cool ! you continue this patch?

comment:9 Changed 6 years ago by xri://=!696F.CBD6.219E.C607

Yes, I do plan to improve it, as I find the time. Suggestions welcome.

comment:10 Changed 6 years ago by asterix

for the entry, maybe looking at GTK code to see what they do, or maybe just show a window containint just an entry that we position in the bottom of roster? Or maybe we could use GTK filter, but we show offline contacts when filter is enabled? I don't know if it is possible to detect when filter is enabled ...

comment:11 Changed 6 years ago by wojtek

  • Cc wojtek@… added

comment:12 Changed 6 years ago by wojtek

  • Cc wojtek@… removed

comment:13 Changed 6 years ago by elsdoerfer

Dup of #5221.

comment:14 Changed 6 years ago by asterix

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.