Opened 9 years ago

Closed 9 years ago

#3483 closed defect (fixed)

Gajim should not PGP-sign presence until it's needed

Reported by: hawke@… Owned by: asterix
Priority: normal Milestone: 0.12
Component: usability Version: hg
Severity: normal Keywords:
Cc: Blocked By:
Blocking: OS: All


Currently gajim PGP-signs presence before attempting to make a connection to the server. This happens even with an automatic reconnect attempt. This means, that when gpg-agent is in use, gajim causes it to pop up a passphrase prompt every minute or so as the reconnects attempts happen. There is no use in actually signing the presence since the connections fail each time. It should probably wait until a successful connection is made and sign presence just before it's actually sent

Change History (3)

comment:1 Changed 9 years ago by asterix

I don't think it's possible: we need to create the XML stanza before trying to send it. So we need the signed presence before we can know network is brocken

comment:2 Changed 9 years ago by anonymous

But the stream can be opened, and stream features / authentication can be negotiated before presence is sent. If the stream can't be opened, there's no need to sign the presence.

comment:3 Changed 9 years ago by asterix

  • Milestone set to 0.12
  • Resolution set to fixed
  • Status changed from new to closed

(In [ccee3d872bc83ca2d34fe9d78b97244b8a726da8]) request GPG password only when connected to server, before sending presence. fixes #3483, #3375, #3115

Note: See TracTickets for help on using tickets.