Opened 9 years ago

Closed 9 years ago

#3358 closed enhancement (fixed)

Smooth scrolling of conversation textview

Reported by: Geobert Owned by: asterix
Priority: normal Milestone: 0.12
Component: chat Version: hg
Severity: normal Keywords: smooth scrolling scroll
Cc: geobert@… Blocked By:
Blocking: OS: All

Description

I like the smooth scroll of Pidgin so I hack Gajim to do it with an ACE option to deactivate it.

See the patch to include it in gajim :)

I have still one thing to do to make it really good: when the message text grow, it smooth scroll the conversation view but I think to not smooth in this case is better.

I try to put a parameter in bring_scroll_to_end to disable the smoothing when called by on_conversation_vadjustment_changed of chat_controler, but it disable the whole smoothing thing.

I don't understand what's wrong :-/ thanks for any help :)

Attachments (6)

smooth_scrolling_patch.diff (5.7 KB) - added by Geobert 9 years ago.
smooth scrolling patch
smooth_scrolling_patch_2.diff (5.7 KB) - added by Geobert 9 years ago.
small bug fix
smooth_scrolling_patch_3.diff (8.4 KB) - added by Geobert 9 years ago.
bug fix
smooth_scrolling_patch_3.2.diff (6.9 KB) - added by Geobert 9 years ago.
silly bug in _3
smooth_scrolling_patch_4.diff (6.9 KB) - added by Geobert 9 years ago.
silly bug in _3
smooth_scrolling_patch_5.diff (7.0 KB) - added by Geobert 9 years ago.
more bug fix

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by Geobert

smooth scrolling patch

comment:1 Changed 9 years ago by anonymous

  • Cc geobert@… added

Changed 9 years ago by Geobert

small bug fix

comment:2 Changed 9 years ago by Geobert

Second version, I've fix a bug and it makes the behavior better when the message text grows. But now, it is when we hit Ctrl-Up it smooth scroll the conversation view. I don't understand why the conversation text grows when we call the history?

Changed 9 years ago by Geobert

bug fix

Changed 9 years ago by Geobert

silly bug in _3

Changed 9 years ago by Geobert

silly bug in _3

comment:3 Changed 9 years ago by Geobert

ok, I've add a flag to disable the smoothing if we hit Ctrl-Up/Down?, but I don't think it is the best way to handle it.

sorry for the mistaken upload _3 and _3.2 :-/

Changed 9 years ago by Geobert

more bug fix

comment:4 Changed 9 years ago by asterix

(In [9359b997d9d62c86208af3acb6647e2c80149314]) [Geobert] Smooth scrolling of conversation textview. see #3358

comment:5 Changed 9 years ago by asterix

TODO: add a GUI option to disable that. depends on #3330

comment:6 Changed 9 years ago by Jim++

I don't think we want a GUI for that.

comment:7 Changed 9 years ago by asterix

  • Resolution set to fixed
  • Status changed from new to closed

ok so let's close this ticket, thanks Geobert

Note: See TracTickets for help on using tickets.