Opened 10 years ago

Closed 6 years ago

Last modified 6 years ago

#2467 closed enhancement (fixed)

Alert when quitting while transferring file

Reported by: jim++ Owned by: asterix
Priority: normal Milestone: 0.14
Component: None Version:
Severity: normal Keywords: FT
Cc: Blocked By:
Blocking: OS: All

Description

When quitting, if we are sending or receiving a file, we should alert user. Like "unread messages" dialog. I think it's not necessary when just disconnecting, but not sure.

Attachments (1)

unfinish_transfers_dialog.patch (2.0 KB) - added by zimio 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by asterix

  • OS set to All
  • Type changed from defect to enhancement

Changed 6 years ago by zimio

comment:2 Changed 6 years ago by zimio

I wrote a patch for it.

comment:3 Changed 6 years ago by asterix

Thanks for the patch, I changed it a bit so that unread message are still checked, even if we accept stopping FT.

And I removed your gajim.files_props variable, which is not needed.

comment:4 Changed 6 years ago by Yann Leboulanger <asterix@…>

  • Milestone set to 0.14
  • Resolution set to fixed
  • Status changed from new to closed

(In [edbeb4d0c5c6]) [zimio and I] warn user when quitting while file transfers are running. Fixes #2467

comment:5 Changed 6 years ago by zimio

Because from common.protocol.bytestream import (is_transfer_active) is no longer in roster_window.py it gives this error: NameError?: global name 'is_transfer_active' is not defined

comment:6 Changed 6 years ago by asterix

Oups, thanks

comment:7 Changed 6 years ago by Yann Leboulanger <asterix@…>

(In [b3a57d51994c]) fix missing import. Fixes #2467

Note: See TracTickets for help on using tickets.