Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#1612 closed defect (fixed)

Contact Information dialog: close button

Reported by: Josef Kufner <jk@…> Owned by: nk
Priority: low Milestone: 0.10
Component: dialogs Version: 0.9.1
Severity: normal Keywords: dialog button
Cc: Blocked By:
Blocking: OS:


Hello all,

When I press escape in contact information dialog, it is like i press "cancel" button. And when I press "Close" button, it is like I press "Ok" button. (yes, i can't speak english :) )

The contact information dialog works like dialog with cancel and ok button (it's fine), but it has only close button. It is confusing. I suggest to replace one "Close" button with "Cancel" and "Ok" buttons.

Change History (7)

comment:1 Changed 11 years ago by nk

I don't understand well. when you press Escape what happens that is different than pressing Close button? (NOTE: we have not OK button)

comment:2 Changed 11 years ago by Josef Kufner <jk@…>

  1. open info dialog (by right click to contact in roaster)
  1. change nickname text entry in dialog

3a. press escape => nothing

3b. press close button => nick in roaster is changed

comment:3 Changed 11 years ago by nk

  • Owner changed from asterix to nk

we follow GNOME instant apply philosophy. so Close is ok but changes should be made on the fly and not when hitting Close. thanks I'll fix

comment:5 Changed 11 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 11 years ago by asterix

  • Resolution fixed deleted
  • Status changed from closed to reopened

This is absolutly ugly way to do:

when we pass from qwerty to qwe, we send 3 time an updated nick: qwert, qwer and finaly qwe. use the focus out signal instead

comment:7 Changed 11 years ago by nk

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.