Ticket #735 (closed task: fixed)

Opened 4 years ago

Last modified 3 years ago

SRV lookups can return s2s results

Reported by: travis@… Owned by: nk
Priority: lowest Milestone: 0.4
Component: chat Version: 0.10.1
Severity: major Keywords: srv
Cc: Blocked By:
OS: Blocking:

Description

Current xmpp.transports does two possible SRV queries, one of which is meant for s2s connections (legacy s2s connections at that). My work server answered _jabber._tcp. with the3 correct s2s port 5269, which gajim was obviously not expecting to connect with. A simple patch, for now, is to remove this query (see attachment). Another is bug is that this SRV lookup prevents custom ports from being used if one of the queries returns a result. The patch does not address this.

Attachments

srv.patch (437 bytes) - added by travis@… 4 years ago.
SRV patch

Change History

Changed 4 years ago by travis@…

SRV patch

Changed 4 years ago by nk

  • owner changed from asterix to nk
  • milestone set to 0.9

why remove it? I did not understand sorry

about the other pb it's not a problem. if the server has SRV the admin should have the correct ports

Changed 4 years ago by travis@…

It should be removed because the answer to the query is always going to be the port 5269, which server to server, not client to server (5222, or 5223).

Changed 4 years ago by nk

  • status changed from new to closed
  • resolution set to fixed

thanks a lot

Add/Change #735 (SRV lookups can return s2s results)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
Next status will be 'needinfo'
 
Note: See TracTickets for help on using tickets.