Ticket #734 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

Error with binary files transfert

Reported by: khaelin@… Owned by: dkirov
Priority: normal Milestone: 0.9
Component: None Version: hg
Severity: major Keywords: file transfert
Cc: Blocked By:
OS: Blocking:

Description

Binary files sent by gajim are altered.

- With jpg image: display: Not a JPEG file: starts with 0x0d 0xff.

- With png image: display: Improper image header `tux_crystal.png'.

- With zip file: p7zip Version 4.20 (locale=fr_FR@euro,Utf16=on,HugeFiles?=on) Processing archive: tux.zip Error: tux.zip is not supported archive

Attachments

Change History

Changed 5 years ago by dkirov

  • owner changed from asterix to dkirov
  • status changed from new to assigned

Just to assure that PB is in gajim. Which jabber client uses the peer, gaim?

Changed 5 years ago by nk

if it is Gaim and it is Gaim bug, then Gaim should fix it and it should be a bug against Gaim

Changed 5 years ago by anonymous

same problem here trying to send a file to a buddy using kompete,

i was also not able to receive a file from kompete. (this again could be a problem with kompete)

Changed 5 years ago by nk

can you test against latest svn? I believe it should be fixed.

if not, please attach one of the files you are trying to send and end up corrupted.

Thank you

ps. if the other party runs Gajim 0.8 in Windows, then it's fixed in 0.8.1

Changed 5 years ago by nk

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to 0.8

reopen if you still have it with svn or with 0.8.1 that's gonna come soon

Changed 5 years ago by kaalh@…

  • status changed from closed to reopened
  • version changed from 0.8 to svn
  • resolution fixed deleted
  • milestone changed from 0.8 to 0.9

this hack seems to fix it :

Index: src/common/socks5.py ===================================================================

--- src/common/socks5.py (révision 3481) +++ src/common/socks5.py (copie de travail) @@ -171,7 +171,7 @@

reader.file_propsstalled? = False reader.file_propsreceived-len? = 0 reader.pauses = 0

- reader.send_raw(reader._get_nl_byte()) + # reader.send_raw(reader._get_nl_byte())

result = reader.write_next() self.process_result(result, reader)

Changed 5 years ago by nk

putting it in 3 { and closing with 3 }

 Index: src/common/socks5.py
 ===================================================================

 --- src/common/socks5.py        (révision 3481)
 +++ src/common/socks5.py        (copie de travail)
 @@ -171,7 +171,7 @@
                        reader.file_props['stalled'] = False
                        reader.file_props['received-len'] = 0
                        reader.pauses = 0
 -                       reader.send_raw(reader._get_nl_byte())
 +                       # reader.send_raw(reader._get_nl_byte())
                        result = reader.write_next()
                        self.process_result(result, reader)

Dimitur, comments?

Changed 5 years ago by dkirov

fixed in svn, thanks

Changed 5 years ago by dkirov

  • status changed from reopened to closed
  • resolution set to fixed

Add/Change #734 (Error with binary files transfert)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Next status will be 'needinfo'
 
Note: See TracTickets for help on using tickets.