Ticket #644 (closed defect: fixed)

Opened 5 years ago

Last modified 3 years ago

JEP 0070 support

Reported by: travis@… Owned by: asterix
Priority: normal Milestone: 0.11.2
Component: None Version: 0.10.1
Severity: normal Keywords: xep 0070
Cc: Blocked By:
OS: Unix Blocking:

Description

This patch adds support for JEP 0070 (HTTP auth). Note, patch for ticket #643 is in this patch as well. Patched against subversion 2767.

Attachments

jep70.patch (9.3 KB) - added by travis@… 5 years ago.
Patch
jep70.2.patch (3.6 KB) - added by asterix 5 years ago.
new patch for JEP 70
jep70.3.patch (1.1 KB) - added by travis@… 5 years ago.
A final patch

Change History

Changed 5 years ago by travis@…

Patch

Changed 5 years ago by asterix

new patch for JEP 70

Changed 5 years ago by asterix

  • milestone set to 0.8

can you try this new patch ? does it seems correct ?

Changed 5 years ago by asterix

  • status changed from new to closed
  • resolution set to fixed

Changed 5 years ago by travis@…

It seems correct, but does not work. I've not had the time today to dive in and figure out why, but the registered handler (_HttpAuthCB) never gets called. Perhaps this is because the child element of the iq is <confirm> and not <query>. Note, that my #643 patch will not fix this, I think the problem is deeper than that (#643 addresses convenience). In order to test, you can always use a client that allows you to send XML (maybe the upcoming XML console will support this?) to send the confirmation iq as descriped in JEP-0070. I'll report more info when I get the chance to do more debugging.

Changed 5 years ago by asterix

  • status changed from closed to reopened
  • resolution fixed deleted

Changed 5 years ago by travis@…

Also, if I try your patch on an existing configuration I get the follwing exception trace:

Traceback (most recent call last):

File "./gajim.py", line 1119, in ?

Interface()

File "./gajim.py", line 1001, in init

parser.read()

File "/home/travis/src/gajim-svn/src/common/optparser.py", line 54, in read

self.read_line(line)

File "/home/travis/src/gajim-svn/src/common/optparser.py", line 37, in read_line

gajim.config.set(var_str, value_str)

File "/home/travis/src/gajim-svn/src/common/config.py", line 338, in set

raise RuntimeError?, 'option %s does not exist' % optname

RuntimeError?: option http_auth does not exist

Is there some way that configs should be migrated? Or one must start anew with a fresh configuration?

Changed 5 years ago by asterix

this bug is known, I temporary fixed it now

Changed 5 years ago by nk

  • status changed from reopened to closed
  • resolution set to fixed

should be ok. if not nicfit plz reopen

Changed 5 years ago by travis@…

  • status changed from closed to reopened
  • resolution fixed deleted

The latest svn (2877) is close, but needs the attached patch to work completely. Note, I've tested with http_auth as ask, yes, and no and everything works well with this small patch.

Changed 5 years ago by travis@…

A final patch

Changed 5 years ago by nk

  • status changed from reopened to closed
  • resolution set to fixed

thank you Travis

Changed 5 years ago by asterix

  • priority changed from highest to normal
  • component changed from preferences to None
  • severity changed from enhancement to normal
  • milestone set to 0.8

Changed 3 years ago by anonymous

  • keywords xep 0070 added
  • os set to Unix
  • status changed from closed to reopened
  • resolution fixed deleted
  • milestone changed from 0.8 to 0.11.2

doesn't really work stable. (With jautod from jauto.sourceforge.net). Gajim doesn't always (indeed it doesn't for the most time) ask for confirmation but instead freezes. Looked for the error, but didn't find anything.

MoKrates?

Changed 3 years ago by anonymous

In trunk it seems to work fine with jautod, but it asks for confirmation for every single file AFAICT. Is this the intended behaviour? I personally find it quite annoying, because that means clicking "Yes" about 5 times if you view a directory listing of just one folder.

Changed 3 years ago by asterix

  • status changed from reopened to closed
  • resolution set to fixed

XEP tells nothing about that, but IMHO it's something that webserver should do, keep in mem auth to not ask it. When gajim get a request, it shows it to user, that sounds normal.

as it works, I close

Add/Change #644 (JEP 0070 support)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Next status will be 'needinfo'
 
Note: See TracTickets for help on using tickets.