Ticket #5593 (closed enhancement: wontfix)

Opened 7 months ago

Last modified 7 months ago

Please add vim config line in all source files

Reported by: Merwok Owned by:
Priority: normal Milestone:
Component: None Version: hg
Severity: normal Keywords:
Cc: Blocked By:
OS: All Blocking:

Description

Hello

Programmers using Vim with a sensible configuration for Python files, say < http://hg.python.org/cpython/file/f9d3092cbc93/Misc/Vim/vimrc>, have to remember that Gajim has its own style. When they try to fix something and send a patch, they can get bitten by this discrepancy and have to rewrite their patch. (This is precisely the sort of stupid things that the Style Guide for Python Code was written to prevent.)

I’d like each file to contain appropriate configuration (noexpandtab and tabwidth=3) to ease the participation of external developers. Thanks.

Regards

Attachments

Change History

Changed 7 months ago by nicfit

If the new indentation is 3 (IIRC it used to be tabs) then :set expandtab is what you want. There is no reason to have tab characters in python files if the indentation is not tab. Also, the referenced vimrc does not use noexpandtab (except for "old" c files).

Changed 7 months ago by Merwok

  • status changed from new to closed
  • resolution set to wontfix

If I understand correctly, noexpandtabs means the source uses tabs, and tabwidth=3 means that tabs should be 3 spaces long—not that they should be replaced by 3 spaces.

My point here was that the source should not require people to remember to use a special configuration.

(The referenced vimrc does not use noexpandtab indeed, because the right style for Python is to use spaces.)

From the chatroom (http://www.gajim.org/muc_logs/gajim@conference.gajim.org/2010/02/07.html#18:02:58.312589):

<johnny> i don't think we should have vimlines at all tho

<johnny> and just use the pep 4 space standard

<steve-e> we already had that discussion and decided do make the switch

<johnny> yes

<johnny> that is true

So I’m very happy to close this bug and wait for/help in converting the source files :)

Add/Change #5593 (Please add vim config line in all source files)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Next status will be 'needinfo'
 
Note: See TracTickets for help on using tickets.