Ticket #4147 (closed defect: fixed)

Opened 5 weeks ago

Last modified 3 weeks ago

Modal windows should not stall connections

Reported by: js Owned by: asterix
Priority: highest Milestone: 0.12
Component: None Version:
Severity: blocker Keywords:
Cc: OS: All

Description

It seems that Gtk's idlequeue is stopped when a modal dialog pops up. This means Gajim doesn't process any network packets anymore when a modal dialog is open. We should either get rid of all modal dialog or use the SelectIdleQueue? (though I haven't tested if the SelectIdleQueue? is unaffected by this, I guess so).

Attachments

Change History

Changed 4 weeks ago by asterix

that's right, it's why there are lessa nd less modal dialogs. Which one is still present?

Changed 4 weeks ago by js

Uhm, I have to look at it. I'll pay more attention to when I got dialogs.

Definitely modal are:

  • Changing status message
  • The Yes/No dialog for a groupchat invitation

Changed 4 weeks ago by asterix

(In [10090]) use PassphraseDialog? only asynchronously. see #4147

Changed 4 weeks ago by asterix

(In [10091]) Use InvitationReceivedDialog? asynchronously. see #4147

Changed 4 weeks ago by asterix

done for groupchat invitation dialog, for chaging status, it is indeed, but there is a timeout, isn't it enough?

Changed 4 weeks ago by js

Well, at least, in this time, all connection traffic is blocked. This will already give XEP-0184 warnings. It would be better to have that non-modal. We should grep for modal, I think, and fix all of them.

Changed 4 weeks ago by js

Oh, plus IF the user started changing it and for some reason paused, it might block for an even longer time!

Changed 4 weeks ago by asterix

(In [10126]) make ChangeStatusMessageDialog? asychronous. see #4147

Changed 4 weeks ago by asterix

  • owner set to asterix
  • status changed from new to assigned

Changed 3 weeks ago by asterix

(In [10138]) make EditGroups? and ChangePassword? dialogs asynchronous. see #4147

Changed 3 weeks ago by asterix

  • status changed from assigned to closed
  • resolution set to fixed

(In [10181]) make ad-hoc cancel warning dialog non-blocking. It was the last blocking dialog ! Fixes #4147

Add/Change #4147 (Modal windows should not stall connections)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.