[PATCH] MPD support

[Florob]

This patch adds support for getting information from MPD for send User Tune.

[asterix]

hmm isn't there a way to get that info without pooling? doesn't MDP send a dbus message or something else when they change status?

[Florob]

Unfortunately not. MPD currently only speaks it's own protocol and doesn't support dbus. And this protocol (or at least that's what I was told) unfortunately relies on polling.

[asterix]

that's sad ... but at least your patch seems to start pooling only when player is running right?

[anonymous]

Yes, trying to connect to the server (or python-mpd not being present) should raise an exception if there is not MPD running, so the code will jump to the except-block before polling is started.

[Florob]

The above (obviously) was me while login wasn't possible.

I'm attaching a updated version that handles pausing/stopping correctly (I only now noticed it was broken). I don't know if your considering this patch for inclusion (I understand that code using polling isn't really nice to have), but for now I just want to get this public in case someone else wants to use it. There still is a bug causing it to not work any more if you haven't played any music for an extended period of time. This is a bit difficult to debug for obvious reasons. If you see anything suspicious in the code I'd be thankful for any help.

[js]

Doing an except with no error specified is bad IMO.

[anonymous]

Replying to js:

Doing an except with no error specified is bad IMO.

Noted. But for now I don't really care. This won't go upstream and I'll probably rewrite it as a plugin once that's possible anyway.

[anonymous]

isn't this a duplicate of #3767 ?