Ticket #3925 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

XEP-0115 version 1.5: verification string's implementation miss data form

Reported by: alban Assigned to: asterix
Priority: normal Milestone: 0.12
Component: None Version: svn
Severity: normal Keywords:
Cc: OS: All

Description

The new XEP-0115 version 1.5 requires to hash indentities, caps and dataforms. This has been implemented in Gajim by the function compute_caps_hash in src/common/helpers.py:

r9508 | asterix | 2008-04-20 23:58:47 +0100 (Sun, 20 Apr 2008) | 2 lines new XEP-0115 implementation (version 1.5)

But the implementation ignores the dataforms. Even if Gajim does not use dataforms, it must parse them to compute the hash correctly. Otherwise, Gajim will reject the whole caps because of the wrong hash.

Attachments

Change History

05/08/08 14:43:33 changed by asterix

  • milestone set to 0.12.

Yes I know about that. I'm on it, but dataforms don't contain the fields types, so our dataform parser doesn't allow several <value> elements. I need to change things ... but it's in my mind :)

05/08/08 16:07:04 changed by alban

I am implementing this on another Jabber client (Telepathy Gabble). Gajim seems to be the first to implement the v1.5 of the XEP, so I am interested to compare the output of compute_caps_hash() and the the equivalent function in Telepathy Gabble for testing the implementations.

05/14/08 20:30:40 changed by asterix

  • status changed from new to closed.
  • resolution set to fixed.

(In [9640]) fix caps hash computaion according to XEP-0115. fixes #3925

Add/Change #3925 (XEP-0115 version 1.5: verification string's implementation miss data form)




Change Properties
Action