Ticket #378 (assigned enhancement)

Opened 3 years ago

Last modified 14 months ago

support sending a roster item (eg. contact) to another contact (XEP-0144)

Reported by: nk Owned by: roidelapluie
Priority: normal Milestone:
Component: None Version:
Severity: normal Keywords:
Cc: md@… OS: All

Description

Attachments

patch-gajim-rosterx-send.diff (3.8 kB) - added by mibus@… 2 years ago.
rosterx sending patch
Capture-Roster Item Exchange.png (24.9 kB) - added by roidelapluie 17 months ago.
add_to_roster.diff (6.4 kB) - added by roidelapluie 16 months ago.
Roster Item Exchange.diff (9.5 kB) - added by roidelapluie 14 months ago.
Not tested yet

Change History

Changed 3 years ago by nk

Changed 3 years ago by Marco d'Itri

  • cc md@… added

The obvious UI for this is drag and drop, this is how gabber used to implement this feature.

Changed 3 years ago by asterix

DND to a chat window, because gajim uses DND in roster to move comtact to another group.

Changed 3 years ago by Marco d'Itri

Yes, this is how gabber used to work too.

Changed 3 years ago by anonymous

"DND to a chat window, because gajim uses DND in roster to move comtact to another group."

Now that Gajim has a DND menu for dragging in the roster, would it be viable to add another menu option?

Changed 2 years ago by hawke

  • type changed from defect to enhancement

Changed 2 years ago by mibus@…

I've just written a patch that supports sending a contact as a 'add'. I've

removed the automatic metacontact-on-drop so you always get the menu option. (Drag one contact onto another in the roster window).

There are two things missing, (1) receiving a contact and adding it, and (2) doing a disco first to make sure the receiver supports rosterx. (That said, I'm adding a body tag to the message so a client not supporting it is still useful as a receiver).

Changed 2 years ago by mibus@…

rosterx sending patch

Changed 2 years ago by mibus@…

I've just looked over the file transfer code and can't see where it does a

disco before trying. Does it try? Where?

If not, then what will it take for this patch to get in to 0.11 or 0.12? Even without a dialog to automatically add a contact to the roster when receving the roster exchange item, it's still useful.

Changed 2 years ago by asterix

indeed we don't do disco for FT, so we could add this patch, but if we are

able to send contacts, we should also be able to receive some. It's weird to do only half. If we have time, we'll do it for 0.11, but not sure

Changed 19 months ago by DoomHammer

This JEP has been superseded by XEP-0144

Changed 17 months ago by roidelapluie

  • owner changed from asterix to roidelapluie
  • status changed from new to assigned

Changed 17 months ago by roidelapluie

Changed 16 months ago by roidelapluie

Changed 16 months ago by misc

  • os set to All
  • summary changed from support sending a roster item (eg. contact) to another contact to support sending a roster item (eg. contact) to another contact (XEP-0144)

Except the part about caps ( the line about ftrans etc), the first patch ( about sending ) seems ok to me.

For the secund one ( about receiving ), wouldn't it be cleaner to use a glade file ?

Changed 14 months ago by steve-e

Don't forget to fix this issue #3177, too.

Changed 14 months ago by roidelapluie

Not tested yet

Add/Change #378 (support sending a roster item (eg. contact) to another contact (XEP-0144))

Author



Change Properties
<Author field>
Action
as assigned
as The resolution will be set. Next status will be 'closed'
to The owner will change. Next status will be 'new'
 
Note: See TracTickets for help on using tickets.