Ticket #3649 (closed enhancement: fixed)

Opened 13 months ago

Last modified 12 months ago

prefer contacts on the same server like your own account in meta-accounts

Reported by: Elmar Hoffmann <elho@…> Owned by: asterix
Priority: normal Milestone: 0.12
Component: None Version: 0.11.4
Severity: normal Keywords:
Cc: OS: All

Description

The attached patch adds the jabber server of a contact as another criteria in compare_metacontacts(), prefering accounts on the same server.

Attachments

gajim-prefer_same_server.diff (0.8 kB) - added by Elmar Hoffmann <elho@…> 13 months ago.
gajim-prefer_same_server-2.diff (0.8 kB) - added by Elmar Hoffmann <elho@…> 12 months ago.

Change History

Changed 13 months ago by Elmar Hoffmann <elho@…>

Changed 12 months ago by asterix

why should an away contact from the same server be over an online contact from another server? I don't see why a contact on the same server is more important, except maybe if you're on a company server, but it's not for everybody in this case

Changed 12 months ago by anonymous

For no reason ;) Actually it should've gone right after the status comparison, not before it... Attaching updated patch.

The main reason for me to prefer contacts on the same server is that public jabber services tend to be quite unreliable in their s2s connections at times. My use case here are people that also have an account on my server, but have that online less often. Another use case would be people with common subsets of accounts different public services communicating with each other.

I do think that ideally one could either give priorities to other servers ("shamelist" of the crap servers ;)) or (which is more average-user-friendly and flexible and thus better, yet more tedious for my use case ;)) drag'n'drop sort the accounts within a meta-account and that would make them stick and being preferred in that order.

Nontheless I do think that this patch makes sense even if sth. like that was implemented, because being on the same server arguably is a better criteria to prefer a contact by default than it being later in the alphabet which the JID comparison boils down to.

Changed 12 months ago by Elmar Hoffmann <elho@…>

Changed 12 months ago by steve-e

I like the idea. +1

Changed 12 months ago by asterix

yep ok. XEP has a 'priority' attribute for metacontacts. Gajim handles it before all other things when the attribute is set on the server, but it doesn't offer a way to set it. The only reason is that I don't see a way to include that in the GUI. If you have an idea ...

Changed 12 months ago by Elmar Hoffmann <elho@…>

Ah, that's what order is. :)

Hmm yeah, the simple solution to add yet another menu item "Set contact priority" wouldn't be that nice... Maybe take a different approach to editing a contact: Do it in the information window, ie. the nickname being a text-field, have an entry for the OpenPGP key there too which is a button that opens the select dialog when pressed, etc. Then there could just be a contact priority field, too.

But still, the drag'n'drop idea sounds like the most straight-forward to use. That one could just automatically set up increasing order values.

Changed 12 months ago by steve-e

You know those music players that rate a song depending on how often you play it?

What about something like this for metacontacts? A brother is rated higher when it is used more often than other siblings.

Changed 12 months ago by asterix

this seems very hard to achieve, meta contacts can be from different accounts. And if we save localy the numberof time we see each jid online, the master contact will depend on where you run gajim from.

For information window, we used to have something like that (editable things in this window) but we switch to a real infomation only window, which only display info. It's better to not mix different things in the same place.

Changed 12 months ago by asterix

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [9238]) [Elmar Hoffmann] prefer contacts on the same server as you in metacontacts. fixes #3649

Add/Change #3649 (prefer contacts on the same server like your own account in meta-accounts)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.