Warn when closing a chat windows with tabs

[bronger]

When the user closes a chat windows which contains two or more tabs, there should be a confirmation window asking whether the user really wants to close all conversations.

[nicfit]

Hmm, is this really that important since you can always just reopen? Recent history is displayed, and older history is accessible so what does this buy us. The one thing would be your tab layout/order.

[bronger]

Okay, let me clarify.

The current option is to get warned when closing a groupchat. I think that this is sub-optimal. If I have a lot of groupchat open, it is even annoying.

I think that the typical user mistake that we should prevent is that you *implicitly* close tabs, i.e. without seeing them. So, the same thing Firefox prevents with its warning.

And there certainly are things to get lost. For example contacts that are not on my roster, a newly given nickname in a MUC, or groupchats that are not protected anymore by the current "warn when close groupchat" option.

So, in my opinion, the current groupchat-closing warning can be dropped in favour of a general tabs-closing warning. I suspect that its origin is actually the implicit closing of tabs, too. Anyway, I wouldn't object to have both.

[nicfit]

Replying to bronger:

Okay, let me clarify. The current option is to get warned when closing a groupchat. I think that this is sub-optimal. If I have a lot of groupchat open, it is even annoying.

Yea, this is pretty annoying. I like the idea, but at one point I had it implemented such that the confirmation of closing mucs was on a per room basis... Meaning, the "don't ask me again" applied to the room and not a global choice.. i.e., don't ever ask me about closing *this* room again.. I still think that is a better option, but I digress.. :)

I think that the typical user mistake that we should prevent is that you *implicitly* close tabs, i.e. without seeing them. So, the same thing Firefox prevents with its warning. And there certainly are things to get lost. For example contacts that are not on my roster, a newly given nickname in a MUC, or groupchats that are not protected anymore by the current "warn when close groupchat" option.

Both are good points.

So, in my opinion, the current groupchat-closing warning can be dropped in favour of a general tabs-closing warning. I suspect that its origin is actually the implicit closing of tabs, too. Anyway, I wouldn't object to have both.

Yea, this is the choice to make here. A confirmation dialog for the entire message window would negate the need for the muc version...

[asterix]

I agree that one window per groupchat is annoying. But if you have several tabs with only chats, I see no reason to have a warning window as, as nicfit said, you can just reopen chat window (event if contact is not in the roster, it's shown in roster in "not in roster" group).

So I still think that ignoring chat tabs is good. Firefox can't reopen closed tabs, so it's not really the same behaviour.

So what about:

• if no muc in tabs, just chose tabs
• if one muc in the tabs, show the current warning window with checkbutton
• if several muc, show only one warning window without checkbutton

[bronger]

Granted, I didn't think about the "not in roster" group. However,any markup in the conversation is still lost, and a couple of days ago, I lost a groupchat contact this way. He had contacted me privately while I was absent for a couple of hours, and had left the groupchat meanwhile.

All this seems to be pedantic, so I won't try to find other scenarios in which you lose information when closing a chat window.

Actually my intention with this request is simply to meet the typical expectations of a user (well, as I think they are): If you close a window, you expect to close what you see. Hidden things that were closed implicitly may annoy you, whether they can be retrieved or not.

So I think you shouldn't add too much magic to it. My suggestion is to keep it as simple as possible, and to implement the Firefox behaviour. Additionally, many users are already used to this feature.

[asterix]

Once again firefox don't have the same problem as when you close a tab you can't get it back, in Gajim you can.

"typical expectations of a user (well, as I think they are):" if I want to close one chat I close only one tab, if I want to close them all, I close window, and I don't want to have to say ok in a warning dialog.

I'm not against a warning window, but only if there are tabs that you can't get back easily (like private messages, or groupchats that won't be minimized to roster. That's my opinion.

[bronger]

I didn't get it across properly: When I said "expectations", I meant "errorneous expectations". You close the window, and you don't realise that you close more than you can see, because normally, closing a windows does mean that you close only what you see. I agree with you that if the user is aware of the tabs when closing the window, there is no need for such a thing. Well, *if* ... ;-)

I don't understand why you want it to implement in a such complicated way, i.e. with a distinction of cases when information would be lost for good or not. This is all but simple: There are groupchats, groupchat contacts, chats with markup, chats with a certain mode of encryption, chats with people who are offline for a while so that I have to switch on "show offline contacts", chats with unfinished messages in the edit box. Additionally, I would be annoyed to have lost the tabs even if I can re-open them again. So, just keep it simple (to explain to the user and to implement).

[bronger]

Replying to bronger:

[...] [...] This is all but simple: [...]

Sorry, this should have been: "This is not simple"

[asterix]

I agree that there are many cases, I didn't thought to all of them, but if we just have a warning window, I'll disable it for sure first time I'll see it cause most of the time I know what I do, but the day I'll really loose something, I won't have the warning window. Sure you can answer, you just have to not disable this window ... But most of the time this window will annoy me if I let it open.

Noew for my my case I can live without this window, or disable it cause I know what I do when I close the whole window, but I don't know what most users would want ...

[bronger]

I know what you mean but I have no simple answer to that I'm afraid. I think all important use cases have been mentioned now, so just make a decision when you have time. I'm sure I will be able to live well with it.