Ticket #3584 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

utf8 pb in dialogs.py

Reported by: Dicson Owned by: asterix
Priority: normal Milestone: 0.11.4
Component: None Version: svn
Severity: normal Keywords:
Cc: OS: Unix

Description

Traceback (most recent call last):

File "/home/test/gajim/src/dialogs.py", line 460, in on_message_combobox_changed

self.message_buffer.set_text(self.preset_messages_dict[name])

KeyError?: u'\u044b\u0432\u0430\u044b\u0432\u0430'

Attachments

patch (0.5 kB) - added by anonymous 9 months ago.
patch1 (441 bytes) - added by Dicson 9 months ago.

Change History

Changed 9 months ago by Dicson

  • version set to svn
  • os changed from All to Unix

svn r9054

Changed 9 months ago by anonymous

Changed 9 months ago by Dicson

i have this tb then i Save as Preset Status Message.patch fix my pb

Changed 9 months ago by Dicson

I was mistaken

Changed 9 months ago by asterix

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [9058]) [Dicson] fix utf-8 encoding problem. fixes #3584

Changed 9 months ago by asterix

(In [9059]) [Dicson] Fix utf-8 encoding problem. fixes #3584

Changed 9 months ago by asterix

  • milestone changed from 0.12 to 0.11.4

Changed 9 months ago by anonymous

  • status changed from closed to reopened
  • resolution fixed deleted

Changeset 9058 not fix this problem.I am sorry. I save as Preset Status Message and have Tb. In dialogs.py i do this :

def on_message_combobox_changed(self, widget):
		self.countdown_enabled = False
		model = widget.get_model()
		active = widget.get_active()
		if active < 0:
			return None
		name = model[active][0].decode('utf-8')
		print name ############### -----------

		self.message_buffer.set_text(self.preset_messages_dict[name])

	def on_change_status_message_dialog_key_press_event(self, widget, event):
		self.countdown_enabled = False
		if event.keyval == gtk.keysyms.Return or \
		event.keyval == gtk.keysyms.KP_Enter: # catch CTRL+ENTER
			if (event.state & gtk.gdk.CONTROL_MASK):
				self.window.response(gtk.RESPONSE_OK)
				# Stop the event
				return True

	def toggle_sensitiviy_of_save_as_preset(self, widget):
		btn = self.xml.get_widget('save_as_preset_button')
		if self.message_buffer.get_char_count() == 0:
			btn.set_sensitive(False)
		else:
			btn.set_sensitive(True)

	def on_save_as_preset_button_clicked(self, widget):
		self.countdown_enabled = False
		start_iter, finish_iter = self.message_buffer.get_bounds()
		status_message_to_save_as_preset = self.message_buffer.get_text(
			start_iter, finish_iter)
		dlg = InputDialog(_('Save as Preset Status Message'),
			_('Please type a name for this status message'), is_modal = True)
		response = dlg.get_response()
		if response == gtk.RESPONSE_OK:
			msg_name = dlg.input_entry.get_text().decode('utf-8')
			msg_text = status_message_to_save_as_preset
			msg_text_1l = helpers.to_one_line(msg_text)
			if not msg_name: # msg_name was ''
				msg_name = msg_text_1l
			msg_name = msg_name.decode('utf-8')

			if msg_name in self.preset_messages_dict:
				dlg2 = ConfirmationDialog(_('Overwrite Status Message?'),
					_('This name is already used. Do you want to overwrite this status message?'))
				resp = dlg2.run()
				if resp != gtk.RESPONSE_OK:
					return
			else:
				
				iter_ = self.message_liststore.append((msg_name,))
				gajim.config.add_per('statusmsg', msg_name)
				# select in combobox the one we just saved 
				self.message_combobox.set_active_iter(iter_)
			gajim.config.set_per('statusmsg', msg_name, 'message', msg_text_1l)
			self.preset_messages_dict[msg_name] = msg_text
			print msg_text ################------------------

in console i have :

/home/test/gajim/src/systray.py:41: DeprecationWarning?: the module egg.trayicon is deprecated; equivalent functionality can now be found in pygtk 2.10

import egg.trayicon as trayicon # gnomepythonextras trayicon

name of preset

Traceback (most recent call last):

File "/home/test/gajim/src/dialogs.py", line 461, in on_message_combobox_changed

self.message_buffer.set_text(self.preset_messages_dict[name])

KeyError?: u'name of preset'

Preset Status Message


line 506 start after line 460.

patch1 fix my problem

Changed 9 months ago by Dicson

Changed 9 months ago by asterix

  • status changed from reopened to closed
  • resolution set to fixed
  • milestone changed from 0.11.4 to 0.12

(In [9072]) [Dicson] fix save preset status message behaviour. Fixes #3584

Changed 9 months ago by asterix

(In [9073]) [Dicson] fix save preset status message behaviour. Fixes #3584

Changed 9 months ago by asterix

  • milestone changed from 0.12 to 0.11.4

Add/Change #3584 (utf8 pb in dialogs.py)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.