Offline/online contacts very bad handling

[m_gol]

The new way of scoring metacontact position in roster doesn't make any sense to me. When a metacontact, consisting of a Jabber account and a transport account (in this case, GG transport), connects via their GG account, their roster icon doesn't go up the roster, making me unable to see it when my friend connects only via GG.

I attached 2 screenshots, one with folded metacontact and one with unfolded one.

[m_gol]

unfolded metacontact

[m_gol]

folded metacontact

[m_gol]

In svn everything's ok about that.

[asterix]

normal, this patch is not in SVN yet ... I'll fix this behaviour before comitting it

[steve-e]

What about this bug? Asterix, have you fixed it?

[m_gol]

normal, this patch is not in SVN yet ... I'll fix this behaviour before comitting it

You know, I think it would be better just to remove this patch before it is finally fixed... It was better to handle with these little bugs than to have metacontacts ALWAYS wrong positioned... This makes stable Gajim unusable for people having metacontacts in roster.

When I install Gajim for others, I prefer to install 0.11.1 than 0.11.2 or 0.11.3. And this ticket is the main reason...

[asterix]

(In [9027]) in metacontacts, if one contact is offline and one is not, the online one has a higher priority. fixes #3464

[m_gol]

Who changed a milestone? Will it be included in 0.11.4?

[asterix]

I did, sorry, and yes it will be included in 0.11.4

[m_gol]

When will it be added to svn?

[asterix]

done in [9043]

[m_gol]

Oh, this patch is bad. Now the situation I mentioned exists not only in 0.11.2 and 0.11.3, but also in svn. Look at the screenshots, now I have the same in my roster.

[m_gol]

I've just realised that it doesn't work simply because... it is not commited in [9043]. Look at the published patch and - afterwards - at the changes in [9043]... They don't match to each other.

[m_gol]

I mean, a patch from [9027] is not included in [9043].

[asterix]

(In [9044]) fis metacontact behaviour. fixes #3464

[m_gol]

Metacontacts handling haven't worked well even since this patch was applied. It still often happens to me to have online people below offline ones, especially when one logins according to this: 1) Logged into Jabber 2) Logged into Gadi-Gadu 3) Logged out of Jabber

I have latest svn, but it didn't work in previous svn versions of Gajim, too.

[m_gol]

That was me, sorry for I didn't log in.

[asterix]

(In [9280]) re-compute big brother when a contact of a metacontact goes offline. fixes #3464

[m_gol]

I have latest svn and it still doesn't work. And it concerns usual contacts, too. It is visible especially when it happens for gg transport to disconnect. Then, massively, all my gg contacts get disconnected, but not each of them goes down in roster.

Something wrong was (and I hope is not now) with metacontacts handling, but here is something more about contacts handling, generally...

[asterix]

I can't reproduce any strange behaviour. The scenario you exposed is fixed in svn now. Could you give me a scenario where things are not done correctly?

[asterix]

ping?

[anonymous]

Replying to m_gol:

Then, massively, all my gg contacts get disconnected, but not each of them goes down in roster.

This is suppose to be fixed in r9284.