Ticket #3460 (closed defect: fixed)
Gajim show adhoc command when there is none
| Reported by: | misc | Owned by: | asterix |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.3 |
| Component: | dialogs | Version: | svn |
| Severity: | normal | Keywords: | |
| Cc: | OS: | All |
Description
It seems gajim do not validate the answer sent by server when doing adhoc command discovery. Here is the exchange i have seen :
<iq to="epxample.org" type="get" id="218" from="misc@example.org/Gajim"> <query xmlns="http://jabber.org/protocol/disco#items" node="http://jabber.org/protocol/commands" /> </iq> <iq to='misc@example.org/Gajim' from='example.org' type='result' id='218'> <query xmlns='http://jabber.org/protocol/disco#items'> <item jid='chat.example.org' name='' /> </query> </iq>
The server do not support adhoc command nor advertise it, yet, it answer something ( because it doesn't take in account the node attribute ).
Yet, gajim show a empty windows with a list choice widget without more information.
I think gajim should check the node attribute of answer to prevent such problem ( and of course, my server should not answer to such query, I will take care of that ).
Attachments
Change History
Note: See
TracTickets for help on using
tickets.
