Ticket #3460 (closed defect: fixed)

Opened 22 months ago

Last modified 20 months ago

Gajim show adhoc command when there is none

Reported by: misc Owned by: asterix
Priority: normal Milestone: 0.11.3
Component: dialogs Version: hg
Severity: normal Keywords:
Cc: Blocked By:
OS: All Blocking:

Description

It seems gajim do not validate the answer sent by server when doing adhoc command discovery. Here is the exchange i have seen :

<iq to="epxample.org" type="get" id="218" from="misc@example.org/Gajim">
<query xmlns="http://jabber.org/protocol/disco#items" node="http://jabber.org/protocol/commands" />
</iq>

<iq to='misc@example.org/Gajim' from='example.org' type='result' id='218'>
<query xmlns='http://jabber.org/protocol/disco#items'>
<item jid='chat.example.org' name='' />
</query>
</iq>

The server do not support adhoc command nor advertise it, yet, it answer something ( because it doesn't take in account the node attribute ).

Yet, gajim show a empty windows with a list choice widget without more information.

I think gajim should check the node attribute of answer to prevent such problem ( and of course, my server should not answer to such query, I will take care of that ).

Attachments

gajim.fix3460.patch (457 bytes) - added by misc 22 months ago.
Patch to fix the issue

Change History

Changed 22 months ago by misc

Patch to fix the issue

Changed 22 months ago by asterix

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [354cb451352cbf117237dd0119fc8f842f505658]) get command list only if server answer with commands namespace. fixes #3460

Changed 20 months ago by asterix

  • milestone changed from 0.12 to 0.11.3

Add/Change #3460 (Gajim show adhoc command when there is none)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
Next status will be 'needinfo'
 
Note: See TracTickets for help on using tickets.