Ticket #3435 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

wrong desktop file bundled in latest tarball

Reported by: misc Assigned to: asterix
Priority: normal Milestone: 0.11.2
Component: None Version: svn
Severity: normal Keywords:
Cc: OS: Unix

Description

It seems there is 2 errors and 2 warnings in the file shipped by gajim : 

$ desktop-file-validate data/gajim.desktop
data/gajim.desktop: warning: value "Network;InstantMessaging;Application;GTK;GNOME;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application"
data/gajim.desktop: error: value "0.11.1.4" for key "Version" in group "Desktop Entry" is not a known version
data/gajim.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
data/gajim.desktop: error: value "gajim.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path

The version field is for the version of standard ( ie 0.9.5, for latest ), not for the version of software.

Here is a patch against gajim.desktop.in.in, but since @VERSION@ is no longer used, this part could be simplified. This prevent me to build package using desktop-file-install, and also prevent upload on Mandriva buildsystem, as we check desktop file for correctness.

Attachments

gajim.fix-desktop.diff (0.6 kB) - added by misc on 09/10/07 09:39:58.
fix desktop file

Change History

09/10/07 09:39:58 changed by misc

  • attachment gajim.fix-desktop.diff added.

fix desktop file

09/10/07 16:46:14 changed by asterix

I'm ok to remove Application and to fix the version error, but why do you remove the Encoding part ? and why do you change the icon name ?

09/10/07 16:51:09 changed by misc

The encoding because this is a warning and it seems to be deprecated. I think it is better to have no warning or error.

And the icon because that's a error ( with the latest desktop-utils ), and because as this is seen as a error, it is fatal now.

I do not really care about the encoding, but the icon part is more important.

09/10/07 16:55:39 changed by asterix

I just read the [http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-0.9.5.html spec[ and indeed Encoding is deprecated

but for icon, even in the example it's .png, so I don't understand why it's an error. With my desktop-file-validate it's not (event version=0.11.1.4 is not, so it's not a good validator)

09/10/07 16:56:32 changed by asterix

maybe it should be pixmaps/gajim.png ? cause it's in pixmaps folder

09/10/07 17:02:18 changed by misc

The code of desktop-fileutils was modified before the spec was commited, from what i understood.

09/10/07 17:12:01 changed by misc

For some reason, I said the latest version of spec is 0.9.5, but latest is 1.0, so my patch is wrong.

More ever, the spec example was corrected in HEAD ( 5 minutes ago, but well ), and desktop-file-validate was rewrote ( for latest release ), so that's why it see more errors now.

09/10/07 17:15:01 changed by asterix

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from 0.11.2 to 0.12.

(In [8773]) [misc] updated gajim.desktop file fixes #3435

09/10/07 17:16:18 changed by asterix

(In [8774]) [misc] updated gajim.desktop file. Fixes #3435

09/10/07 17:16:31 changed by asterix

  • milestone changed from 0.12 to 0.11.2.

Add/Change #3435 (wrong desktop file bundled in latest tarball)




Change Properties
Action