Cancelled file transfers still work

[patrys]

I just tried to send a file to a friend. He then mentioned that it might not work as he resides behind a strict NAT and asked me to send it using email. Here's what happened:

1. I initiate the file request in Gajim 2. He tells me to use email instead 3. I click 'cancel' and then 'clean' in the transfer list 4. I switch to Firefox to use GMail 5. A minute later I see a "transfer finished" popup 6. My friend confirms that the transfer was complete 7. I say 'WTF' ;)

This might seem like a little glitch but might be a serious security bug. If the file gets modified between clicking 'cancel' and starting actual transfer (up to the receiving party to pick the right moment), you might disclose critical information.

[kingshivan at gmail]

done ! patch attached

[asterix]

(In [8902]) [kingshivan] really cancel canceled file transfers. fixes #3366

[asterix]

nice ! Just a note for your future patches: use svn diff to create the .diff file ;)

Thanks anyway !