Remove unused code

[Liorithiel]

xmpp/ directory is full of unused code. Much of it belongs to the old xmpppy lib, which Gajim forked. There's a lot of pieces that were probably never tested by their authors (like adhoc commands -- last year i have found several misspellings, which means that code was not even compiled). To keep code clean, this code should be removed.

[roidelapluie]

I had problems with privacy lists too and I don't think the related code has been tested.

[steve-e]

Let us go ahead. Can you please specify the parts of code which should be deleted.

[Liorithiel]

That's to be checked. Disco and adhoc for sure. One could integrate _nb files into the original ones, that would probably remove some code too. It looks like gajim doesn't use roster plugin from xmpp.

[nk]

liori did you rm the unused code so ticket gets closed?

[steve-e]

What about Proxy65Manager and its related classes? Are they finished, have they been tested?

There are at least two errors:

• HostTester? hasn't an idlequeue member
• HostTester? has no disconnect method (which shall be called in ProxyResolver?)

[tomk]

(In [9776]) initial cleanup of xmpppy perfomed, see #3260

[tomk]

I did some cleanup in branches/bosh_support@9776. All was done in xmpp/ folder except for two changes of variable paths in common/connection.py. To summarize it:

• filetransfer.py, session.py, browser.py, commands.py deleted
• methods from CommonClient? moved straight to NBCommonClient and deleted everything from client.py except for PlugIn? class and debug colors.
• two constants from transports moved to transports_nb, transports.py deleted
• methods of Bind and ComponentBind? classes from auth moved to NBBind resp. NBComponentBind in auth_nb, deleted auth.py
• moved stuff from roster to roster_nb and roster.py deleted
• moved four constants from features to features_nb and features.py deleted
• update of imports, init.py

TODO: rename client.py to plugin.py (and change all related import statements)

I merged current (9775) trunk to bosh_support branch just before I did the cleanup. Session tests succeeded and Gajim was working well, but I tried just a few things.