Ticket #3237 (closed defect: fixed)

Opened 18 months ago

Last modified 15 months ago

gajim do not stop the progress bar when requesting information for self contact

Reported by: misc Owned by: asterix
Priority: normal Milestone: 0.11.2
Component: dialogs Version: svn
Severity: normal Keywords:
Cc: OS: All

Description

gajim information dialog ( the one to give vcard of contact ) feature a progress bar used when requesting information. If a client answer "feature not supported", the progress bar do not stop.

step to reproduce : launch gajim (svn) on your account launch mcabber (0.9.2) on your account click on the self presence buddy in gajim, and choose "information in the submenu"

expected result : the progress bar stops soon

current result: the progress bar don't stop.

I suspect the following xml fragment of being the root of the problem :

<iq to="misc@example.org/Mcabber" type="get" id="104">
<query xmlns="jabber:iq:last" />
</iq>

<iq from='misc@example.org/Mcabber' to='misc@example/Gajiml' type='error' id='104'>
<query xmlns='jabber:iq:last'/>
<error code='501' type='cancel'>
<feature-not-implemented xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
</error>
</iq>

I will try to add jabber:iq:last support to mcabber to verify this.

Attachments

gajim.fix3237.diff (0.5 kB) - added by misc 18 months ago.
patch to update own vcard when requested

Change History

Changed 18 months ago by misc

Ok, so i was wrong, it is not lack of jabber:iq:last that cause the problem, because the error also appear with the proper answer.

Changed 18 months ago by misc

  • summary changed from gajim do not detect error message when showing information, and so do not stop the progress bar to gajim do not stop the progress bar when asking question for self contact

Ok, after testing, the problem also occurs with pidgin, so this is not related to client. A race condition maybe ?

My server is not really loaded, so it can answer quite fast to such query.

Changed 18 months ago by misc

  • summary changed from gajim do not stop the progress bar when asking question for self contact to gajim do not stop the progress bar when requesting information for self contact

Changed 18 months ago by misc

Ok so this is because xmppy fire two event, VCARD for all vcard, and MYVCARd for self vcard.

I suggest the following patch.

Changed 18 months ago by misc

patch to update own vcard when requested

Changed 18 months ago by roidelapluie

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [8294]) [misc] Update own vcard when requested. Fix #3237.

Changed 15 months ago by asterix

(In [8684]) [misc] Update own vcard when requested. Fix #3237

Changed 15 months ago by asterix

  • milestone changed from 0.12 to 0.11.2

Add/Change #3237 (gajim do not stop the progress bar when requesting information for self contact)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.