Ticket #3081 (closed enhancement: fixed)

Opened 21 months ago

Last modified 14 months ago

Patch to support avant-window-navigator

Reported by: tristil Owned by: asterix
Priority: normal Milestone: 0.12
Component: roster Version:
Severity: normal Keywords:
Cc: OS: All

Description

With the patch, status changes are reflected in the icon in awn (like Adium). Currently hardwired to Goojim icons.

Attachments

awn.diff (1.6 kB) - added by tristil 21 months ago.
awn-2.diff (3.9 kB) - added by tristil 21 months ago.

Change History

Changed 21 months ago by tristil

  Changed 21 months ago by shin

Fix it for other icons and I'll patch gajim soon after that Thx for your work

  Changed 21 months ago by tristil

Well, what I propose is to introduce a set of dock status images in a separate directory in data/ so that each theme can control them. For now, I can just copy over the other data files into that directory (for example, I used 32x32-sized notification area icons as the icon in the dock for everything but online), but in the future they should probably be separately developed large images (probably SVG). In Adium, the duck holds up signs, closes his eyes, opens his eyes and quacks when there's a message, etc :) What should the directory be called, btw?

  Changed 21 months ago by xombox@…

How can I install this patch?

  Changed 21 months ago by asterix

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [8091]) [tristil] avant window navigator support. fixes #3081

follow-up: ↓ 6   Changed 21 months ago by asterix

Thanks for the patch, it's been added to svn. the problem is that it makes avant-window-navigator segfault in some cases. for exemple when you use sun them and go offline or invisible.

Changed 21 months ago by tristil

in reply to: ↑ 5   Changed 21 months ago by tristil

Replying to asterix:

Thanks for the patch, it's been added to svn. the problem is that it makes avant-window-navigator segfault in some cases. for exemple when you use sun them and go offline or invisible.

Okay, made it so that it checks the iconsets theme directory for a folder "awn" with the icons in it. If it doesn't exist, it defaults to Goojim icons. The Awn guy hasn't made any updates in a while, so I'm not sure if we should invest any more energy in this for the time being. OTOH, I will be happy to add features (animations, etc) to this if development continues on Awn.

  Changed 21 months ago by asterix

The segfault doesn't happen because icon doesn't exists, offline and invisible icons for sun theme exist in 32x32 format. I don't know why awn segfaults.

  Changed 21 months ago by tristil

Maybe there is an unsupported feature in those two pngs, like preserved layers. In any case, I don't get any segfaults, because the patch makes each theme responsible for having an awn folder, else it uses Goojim.

  Changed 21 months ago by asterix

I dont think it's a good idea to add a folder, that is just a copy of 32x32 folder, to support a awn. moreover default theme in gajim is dcraven, not goojim. I think it's ok the way it is. If awn segfaults, it's not really our pb.

  Changed 19 months ago by sb

  • os set to All

It seems that some iconsets don't have 32x32 sized icons is also a reason for not doing anything (I use stellar, no changes happened) Besides, why are there no svg icons for any iconset? IMHO, 32x32 is too small for awn.

  Changed 19 months ago by anonymous

we have SVG on ftp.gajim.org. I never tested to use them directly in Gajim. Maybe that would solve the systray pb ...

  Changed 19 months ago by sb

  • status changed from closed to reopened
  • resolution fixed deleted

The patch does not reflect all status changes that happen, only manual changes through the combo box, right? For example auto-away is not included by that approach.

  Changed 19 months ago by asterix

  • status changed from reopened to closed
  • resolution set to fixed

it does. It reflects the global combobox status

  Changed 19 months ago by sb

Ah, no I see where this comes from. When gajim is minimized to tray, there is no status about the window at all in awn, what I see is the starter icon, which does not recognize that there is a running gajim process. So it is awns fault, sorry.

in reply to: ↑ description   Changed 14 months ago by anonymous

  • severity changed from normal to major

Please, tell us how can we install this plugin!

follow-up: ↓ 17   Changed 14 months ago by anonymous

  • severity changed from major to normal

you have nothing to install, just have AWN installed and python-dbus to communicate with it.

in reply to: ↑ 16   Changed 14 months ago by xombox@…

Replying to anonymous:

you have nothing to install, just have AWN installed and python-dbus to communicate with it.

Thank you for reply.

I have awn and python-dbus package installed trough Synaptics. When I lunch gajim from awn bar and change the gajim status the changed status will not appear on the awn bar. (I use ubuntu 7.10) So how can I make python-dbus communicate with awn?

  Changed 14 months ago by asterix

which Gajim version do you use ? AWN is only in svn

  Changed 14 months ago by anonymous

I use: Gajim 0.11.2 from ubuntu official gutsy repository an avant-window-navigator 0.2.0 from this repository: http://download.tuxfamily.org/syzygy42

  Changed 14 months ago by asterix

you'll have to wait 0.12 release to use AWN, or use svn version or daily snapshot here: http://gajim.org/downloads/snap/

Add/Change #3081 (Patch to support avant-window-navigator)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.