Ticket #3034 (closed enhancement: fixed)

Opened 21 months ago

Last modified 17 months ago

Groupchat into Roster

Reported by: mray Owned by: roidelapluie
Priority: normal Milestone: 0.12
Component: roster Version:
Severity: normal Keywords:
Cc: roidelapluie@… OS: All

Description

The idea is to add a new JID to your roster for every groupchat bookmark.

If you join a groupchat the newly generated contact becomes "online". If you doubleclick one of those new contacts you open the corresponding chatroom. IF YOU CLOSE THE CHATROOM WINDOW the contact in your roster still remains online and you don't quit the room!!! If your nick is mentioned in the room you get a normal contact notification. If nobody said anything in the chatroom the status of the contact in your roster becomes "away" or "xa" ...

Attachments

Capture-[2] Gajim.png (72.6 kB) - added by roidelapluie 19 months ago.
gajim0.png (15.3 kB) - added by roidelapluie 19 months ago.
a groupchat in roster
gajim1.png (70.6 kB) - added by roidelapluie 19 months ago.
context menu where you can minimize the groucphat
gajim2.png (14.5 kB) - added by roidelapluie 19 months ago.
icon changed to 'message' when a message is received
gajim3.png (9.5 kB) - added by roidelapluie 19 months ago.
notification when someone highlights you
groupchats_in_roster.2.diff (17.6 kB) - added by roidelapluie 19 months ago.
groupchats_in_roster.3.diff (24.5 kB) - added by roidelapluie 19 months ago.
groupchats_in_roster.diff (28.6 kB) - added by roidelapluie 19 months ago.

Change History

  Changed 19 months ago by roidelapluie

Here you are. You can now add groupchats to roster.

  Changed 19 months ago by roidelapluie

my patch allow you to minimize groupchats you're in. I don't think it's usefull to do this with bookmarks.

Changed 19 months ago by roidelapluie

  Changed 19 months ago by roidelapluie

  • cc roidelapluie@… added
  • owner changed from asterix to roidelapluie
  • status changed from new to assigned

* attachment groupchats_in_roster.diff added.

Fix bug with couting contacts in Groupchats group

  Changed 19 months ago by roidelapluie

Fix notifications.

Changed 19 months ago by roidelapluie

a groupchat in roster

Changed 19 months ago by roidelapluie

context menu where you can minimize the groucphat

Changed 19 months ago by roidelapluie

icon changed to 'message' when a message is received

Changed 19 months ago by roidelapluie

notification when someone highlights you

Changed 19 months ago by roidelapluie

  Changed 19 months ago by roidelapluie

Voilà.. The last patch seems to be good.

Changed 19 months ago by roidelapluie

  Changed 19 months ago by roidelapluie

groupchats_in_roster.3.diff (24.5 kB) - added by roidelapluie on 05/02/07 15:52:03.

  • Add tooltips
  • Fix draw_contact
  • Fix timestamp for status print
  • Add 'minimize_autojoined_rooms' to ACE; if True, autojoigned rooms are minimized at launch.

  Changed 19 months ago by roidelapluie

attachment groupchats_in_roster.diff added.

  • Change [Hidden] to [Minimized] in tooltips
  • Add French Translation

Changed 19 months ago by roidelapluie

  Changed 19 months ago by roidelapluie

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [8126]) (Fix #3034) Add ability to minimize groupchats in roster, and to minimize autojoigned bookmarked rooms at launch.

  Changed 19 months ago by anonymous

It would be nice if there would be number of participants of the MUC in parenthesis after the MUC name. Example: gajim@… (23)

  Changed 19 months ago by anonymous

Or better yet the number could be in the same format as the other numbers in roster so (available/all participants). Example gajim@… (5/23)

  Changed 19 months ago by asterix

in roster we count connected/total. In groupchat connected = total.

  Changed 18 months ago by anonymous

  • os set to All

Why not put all bookmarks in roster. It would be easier to manage them not having to find bookmars thourgh menus and roster would be consistent with other jabber clients (exodus (http://exodus.jabberstudio.org/collapsed.png), tkabber (http://tkabber.jabber.ru/files/screenshots/tkabber-0.9.5/tkabber_warm.png), bombus etc.). Not joined groupschats can be grayed out like offline contacts.

follow-up: ↓ 14   Changed 18 months ago by steve-e

  • status changed from closed to reopened
  • resolution fixed deleted

roidelapluie, what you have done so far is really great, well done. Nevertheless he last bits are missing to make this new feature usable.

It is confusing to have similar ways to achieve almost the same. What I can currently do:

  • Auto connect a room and minimize it to roster
    • good:
      • is fairly stable
    • bad:
      • auto-minimize on auto-start is hidden in ACE
      • there is not option to minimize instead of closing. You have to use minimize function every time.
  • Add a gc-jid to roster
    • good:
      • the item stays in my roster, even when opened
      • closing window means minimize (very cool)
      • you can move it to the group you want
    • bad:
      • you cannot remove it
      • it only works when you are online, otherwise gajim thinks this is normal contact
      • I cannot disconnect via context menu
    • questionable:
      • how do other clients behave when they find a GC in my contactlist? (XEP?)

I don't want to have all my bookmakrs listed in my roster, only thouse I use regularly.

in reply to: ↑ 13 ; follow-up: ↓ 15   Changed 18 months ago by asterix

Replying to steve-e:

roidelapluie, what you have done so far is really great, well done. Nevertheless he last bits are missing to make this new feature usable. It is confusing to have similar ways to achieve almost the same. What I can currently do: * Auto connect a room and minimize it to roster * good: * is fairly stable * bad: * auto-minimize on auto-start is hidden in ACE

We'll add a minimize on startup checkbutton in manage bookmark window

* there is not option to minimize instead of closing. You have to use minimize function every time.

The one in action popup menu will become a checkbutton "minimize on close"

* Add a gc-jid to roster * good: * the item stays in my roster, even when opened * closing window means minimize (very cool) * you can move it to the group you want * bad: * you cannot remove it

Why that ?

* it only works when you are online, otherwise gajim thinks this is normal contact

normal it's in roster ... IMHO it's not a good thing to add jid to roster.

* I cannot disconnect via context menu

If we keep groupchat in roster we can fix that indeed

* questionable: * how do other clients behave when they find a GC in my contactlist? (XEP?)

I know that Gajim had problems with that a long time ago. I don't know for others

I don't want to have all my bookmakrs listed in my roster, only thouse I use regularly.

and how can Gajim know the one you want in roster ? I don't think one more checkbutton in manage bookmark is a solution. That would do too much options there.

in reply to: ↑ 14 ; follow-up: ↓ 17   Changed 18 months ago by steve-e

* Add a gc-jid to roster

Why that ?

roidelaplui told be about that... Don't do that at home kids :P

bookmarks in roster

and how can Gajim know the one you want in roster? I don't think one more checkbutton in manage bookmark is a solution. That would do too much options there.

No, I don't want that feature. I just wanted to point out that it is not usable, when you have many bookmarks. The current bookmark handling is fine for me.

The rest sounds great.

  Changed 18 months ago by asterix

(In [8272]) add minimize button to manage_bookmarks window. see #3034

in reply to: ↑ 15   Changed 18 months ago by anonymous

Replying to steve-e:

* Add a gc-jid to roster

Why that ?

roidelaplui told be about that... Don't do that at home kids :P

bookmarks in roster

and how can Gajim know the one you want in roster? I don't think one more checkbutton in manage bookmark is a solution. That would do too much options there.

No, I don't want that feature. I just wanted to point out that it is not usable, when you have many bookmarks. The current bookmark handling is fine for me.

All bookmars in roster work just fine with most jabber clients which have proper bookmarks support, as pointed out couple of messages a ago, so I don't really see why Gajim should have this kludge to have bookmars in many different places.

  Changed 18 months ago by asterix

(In [8277]) minimize menuitem -> minimize on close checkbutton. see #3034

  Changed 17 months ago by roidelapluie

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in SVN. Add ability to join a new room minimized.

Add/Change #3034 (Groupchat into Roster)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.