Ticket #3008 (closed defect: fixed)

Opened 23 months ago

Last modified 17 months ago

remote command status changing is producing a traceback

Reported by: misc Owned by: asterix
Priority: normal Milestone: 0.11.2
Component: xmpppy Version: svn
Severity: normal Keywords:
Cc: OS: All

Description

When i try, either with psi or gajim, to remotly execute the command "change status information", i receive this traceback :

Traceback (most recent call last):
  File "/home/misc/checkout/svn/gajim/src/common/xmpp/idlequeue.py", line 132, in process_events
    obj.pollin()
  File "/home/misc/checkout/svn/gajim/src/common/xmpp/transports_nb.py", line 359, in pollin
    self._do_receive()
  File "/home/misc/checkout/svn/gajim/src/common/xmpp/transports_nb.py", line 492, in _do_receive
    self.on_receive(received)
  File "/home/misc/checkout/svn/gajim/src/common/xmpp/dispatcher_nb.py", line 352, in dispatch
    handler['func'](session,stanza)
  File "/home/misc/checkout/svn/gajim/src/common/commands.py", line 345, in _CommandExecuteCB
    rc = obj.execute(iq_obj)
  File "/home/misc/checkout/svn/gajim/src/common/commands.py", line 138, in changestatus
    self.connection.connection.send(response, presencetype == 'offline')
  File "/home/misc/checkout/svn/gajim/src/common/xmpp/dispatcher_nb.py", line 429, in send
    self._owner.Connection.send(stanza, True)
TypeError: send() takes exactly 2 arguments (3 given)

Attachments

gajim.fix3008.patch (475 bytes) - added by misc 23 months ago.
patch to fix the issue

Change History

Changed 23 months ago by misc

patch to fix the issue

Changed 22 months ago by asterix

  • milestone set to 0.12

the patch does not really fix the problem: the problem is in commands.py line:

self.connection.connection.send(response, presencetype == 'offline')

this presencetype == 'offline' is considered as is_message argument in the send function, but has nothing to do with that. Liori wanted an argument to say "send instantly instead of adding to queue" but there is no such option in xmpppy for the moment.

Changed 22 months ago by asterix

  • status changed from new to closed
  • resolution set to fixed

(In [8014]) add a now argument to the send function, so that stanza is sent instantly instead of added to queue. Use it to send answer to adhoc command when we disconnect. fixes #3008 and #2808

Changed 17 months ago by roidelapluie

(In [8632]) add a now argument to the send function, so that stanza is sent instantly instead of added to queue. Use it to send answer to adhoc command when we disconnect. fixes #3008 and #2808

Changed 17 months ago by roidelapluie

  • os set to All
  • milestone changed from 0.12 to 0.11.2

Add/Change #3008 (remote command status changing is producing a traceback)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.