Usability improvements

[batrakov@…]

Hi,

Here are some features that probably may be useful:

1. Quoting: now the only way to quote your interlocutor is copy his text, insert ">" in message line and paste the text. It would be nice if we have some shortcut (alt-q or smth. else) to quote a buddy. Once shortcut is pressed - last buddy's phrase appears quoted. If shortcut is pressed once again - pre-last phrase appears and so on. If qouted text was also highlighted in message window, I would be happy :)

2. Message notifications (as far as i understand) appear only if someone writes to you first time. Could I configure them to appear on every message?

3. We are unable to view oflline users only in one group. So it would be nice if we were able to click on group's header and select "view offline users here"

4. Ability to configure "tab auto opening": when someone writes you and he isn't in your message container - open new tab for him in background and notify about new message.

Thank you!

[steve-e]

Quoting: Why do you want to quote the message you just received? Quoting is needed to ensure that both people know what they each other talk about. In a live chat this is the case almost anytime. I propose wontfix.

[batrakov@…]

Sometimes it's necessary. Example:

User1: Will you implement quoting feature?

User1: And message notifications as well?

User2:

Will you implement quoting feature?

yes

User2:

And message notifications as well?

maybe

[anonymous]

1. Quoting: In your example it is usable, yes. But what if you only want to quote the first message you received? You have to shrink the quote to what you want, I wouldn't call that a real improvement. In general I do not think that quoting in IM is useful. You can express pretty easy what you talk about, so I have not missed yet. Furthermore quotes might even be disturbing for the one who is quoated, because he has to re-scan his statements.

2. Message notifications: It would be cool to have notification for every message I receive when chat window has no focus.

4. Ability to configure "tab auto opening": Isn't that just "Pop it up"-Option? (untested)

[batrakov@…]

I wouldn't call that a real improvement

but if it was added it would be yet another nice feature that might be usefull not only for me

In general I do not think that quoting in IM is useful

Almost all Windows IMs have it, in Linux ones I found it only in SIM. And looks like nothing changes :) BTW: what are ctrl-up and ctrl-down for? they allow me to cycle through _my_ messages, is it more useful than the feature i request? :)

Furthermore quotes might even be disturbing for the one who is quoated, because he has to re-scan his statements.

Highlighting will help here, i think

[steve-e]

Ok, your point :-) Maybe you can investigate how other client handle this exactly and then convince Asterix to implant this feature. What do you mean with highlighting? I talked about the person who is quoted.

[anonymous]

Maybe you can investigate how other client handle this exactly and then convince Asterix to implant this feature

The most convenient implementation i've seen was in R&Q. It acted like ctrl-up and ctrl-down in Gajim now but cycled through your buddy's messages. so you hadn't had to switch to mouse, select text, switch to keyboard, press ">" and then paste the quote. Miranda makes the same thing in some annoying way: you should select the text you quote and press а button to paste it quoted to message buffer. Or you could quote last message in message log whoever has sent it (the dumbest behaviour imho) pressing thi button without text selection.

What do you mean with highlighting?

That text that was quoted is shown (for example) italic and green in message log each time your buddy receives the message. of course if he has gajim as well :))

[steve-e]

This isn't a priority for now. We can take care of when a profound solution is found.

[Yrogirg]

Hello! I got some kind of solution for quoting. Actually, I`m not a programmer, so the solution may be awful.

There are some changes to conversation_textview and chat_control. This files are attached. I also attached the screenshot showing the new function.

If these changes are ok. I'll also try to make quotations look somehow special in the conversation window (e.g. color, font).

P.S. For the quoting icon in the menu I used chat.png.

[Yrogirg]

Oh, just now found a defect -- when you try to web search (or look in wikipedia selected phrase) with the firefox not running, there may be some errors due to special symbols like : (as I understand).

Just try finding something like "[19:18:49] Yrogirg: something wrong" with closed firefox.

[Yrogirg]

Will somebody answer? Anyway, Here are some changes to eneble highlighting quotes.

In coomon/config.py add

'quotedmsgcolor': [ opt_color, '#1EA6AA', '', True ],

in gajim.py add to enable quote spesial text

quote = r'[\r|\n]>.*'

basic_pattern = links + '|' + mail + '|' + quote

And I attached changed conversation_textview.py and chat_control.py

[asterix]

as steve-e said, it's not a priority for now, we want to release ASAP, and that won't be in 0.12. Unfortunatly I don't have time now to read and test your code. But you'll get feedback as soon as I can

[anonymous]

That is the function of "quoting" can not be used? I was not able to do so, using your attached file

2batrakov: вы не русскоязычный?

[anonymous]

русскоязычный, да. но патч не пробовал, жду когда он из коробки будет доступен :) the text above says that we are, the Russian users of Gajim, are waiting for a patch to be applied to official Gajim's code tree to have such a long-awaited feature in our favourite messenger to use.

[asterix]

one things: the requester want to have a quote function without the mouse (alt+q to quote latest received message)

I don't know what is better: your solution enables the possibility to quote only a part of the message, but require to use mouse.

Could you attach a diff rather that the full file?

[asterix]

(In [1ab7fc0549714d6878f9fd9ea77ca134637fb41c]) [Yrogirg & I] add a first quote ability. see #2943

[asterix]

I modified your patch and add quote from context menu.

TODO: alt+q to get latest received message and cycle through them.