Ticket #2932 (closed enhancement: fixed)

Opened 23 months ago

Last modified 4 months ago

click behavior is inconsistent between roster and tray icon

Reported by: qsorix@… Owned by: asterix
Priority: normal Milestone: 0.12
Component: systray Version: svn
Severity: normal Keywords: patch, discussed
Cc: OS: All

Description

Hi,

You have to use different buttons to open incoming chat/message when clicking on roster (middle click) and tray icon (left click). It would be better to have the same action binded to the same buttons. Middle (or double) click to open chat and left button to show/hide roster or select contacts.

Thanks, Thomas 'QsoRiX' Rydzynski

Attachments

config.diff (0.8 kB) - added by radious 19 months ago.
systray.diff (2.5 kB) - added by radious 19 months ago.

Change History

  Changed 23 months ago by asterix

dubble click on roster is the same as middle click.

dubble click on systray is useless and not the standard behaviour of systray.

I propose wontfix

  Changed 23 months ago by anonymous

Well, I do not use double clicks and agree with you here. It was not, however, what I wanted to say.

The problem is that you use middle button to open message from roster and left button to open it from tray icon. It is harder to learn.

I reject wontfix :P

  Changed 23 months ago by junglecow

I have to agree with anonymous here. What if I want to popup the roster when there are pending messages?

  Changed 23 months ago by asterix

use middle click to show roster

IMHO left click should do the most usefull action. In this case opening the event sounds like the most usefull action. middle click to open event is really not intuitive.

middle click in roster to open event is just a shortcut. the standard way is to dubble click

  Changed 23 months ago by qsorix@…

It is very bad when one button can trigger different actions. Period.

In my case it simply drives me mad when I have to click one button on roster and the other one in tray icon. Especially when clicking on the tray icon may not show the roster as usually because it just happened that someone wrote to me.

There is no such thing as "most useful action". Most mouses have three buttons and nobody thinks "Hmm... what would be the most useful action now?" before clicking. Humans have reflexes and they think much faster then the eyes do.

  Changed 23 months ago by asterix

it seems each person have different reflex. behaviour has always been the same and youre the first one who complain.

mine is: ho my systray move, let's click on it to see whan happens. That's why I never thought the behaviour was bad.

Now let me add that with psi left click always toggle roster appearance, middle click to open event

  Changed 22 months ago by asterix

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [7987]) change click on systray behaviour. left click always toggle roster appearance, middle lcick to open pending events. fixes #2932

Changed 19 months ago by radious

Changed 19 months ago by radious

  Changed 19 months ago by radious

  • status changed from closed to reopened
  • type changed from defect to enhancement
  • version set to svn
  • resolution fixed deleted

I think that receiving messages by middle click is weird not only for me, so i fixed that and send you diffs. I now adding yet another advanced option is weird too but i don't know other solution.

  Changed 17 months ago by roidelapluie

  • keywords patch, discussed added
  • os set to All

  Changed 15 months ago by asterix

as already said in this ticket, we did that to be consistant between click in systray and click in roster. I know psi is not a reference, but they do the same. I don't know for other clients. I propose to let it the way it is now.

  Changed 13 months ago by asterix

  • status changed from reopened to closed
  • resolution set to fixed

follow-up: ↓ 14   Changed 4 months ago by anonymous

  • status changed from closed to reopened
  • resolution fixed deleted

IMO, middle click should always show the roster, left click open an event if there is one and if not show the roster. This is the only consitant behaviour as this is what all other applications do. If a tray icon has an event, the user expects to open that with left click. Gajim however doesn't do that anymore, it shows the roster. The user is confused now why the event wasn't opened.

Additionally to that, middle click is not available on Win32, which means you can't open an event from the tray anymore. This is really user unfriendly as the user always has to open the roster and search for the event and click it there.

I vote for reverting it to the old behaviour, it was far more consistent with other applications and what the user expects.

  Changed 4 months ago by js

Oh, that last comment was done by me, forgot to login, sorry.

in reply to: ↑ 12   Changed 4 months ago by asterix

Replying to js:

IMO, middle click should always show the roster, left click open an event if there is one and if not show the roster. This is the only consitant behaviour as this is what all other applications do. If a tray icon has an event, the user expects to open that with left click. Gajim however doesn't do that anymore, it shows the roster. The user is confused now why the event wasn't opened.

please read previous comments: not all applications do that. I citted psi that does as us.

Additionally to that, middle click is not available on Win32, which means you can't open an event from the tray anymore. This is really user unfriendly as the user always has to open the roster and search for the event and click it there.

I Agree that gtk.statusicon is very buggy and incomplete. But it'a not because it's buggy that we have to be inconsistant with the way we open an event in the roster: middle click

  Changed 4 months ago by js

Psi is the only application doing it with middle click, and also only doing that in SVN. (At least, old versions always worked with left click for me). All other IMs I know use left click: Pidgin, Miranda, SIM, QIP, ICQ, Kopete, etc. So Psi are the ones being inconsistent. Why would we want to copy that?

  Changed 4 months ago by asterix

but it's not consistant with the way we open a chat window in roster, which is the topic of this ticket

  Changed 4 months ago by js

Yeah, but you closed the ticket with the topic that the new behaviour is unexpected and said we should continue the discussion here, which is just what I do. I'm still for the old behaviour as this is more consistent with the rest. If we want consistency with the roster, we wouldn't use middle click anyway, but double click.

  Changed 4 months ago by asterix

I'm not against implementing dubble click in systray. The only thing is that the first click will also generate a button_press event. So we have to delay this action the time we're sure it's not a dubble click. This time is configurable, but maybe we can get it from GTK somewhere?

  Changed 4 months ago by asterix

gtk.settings_get_default().get_property('gtk-double-click-time')

  Changed 4 months ago by asterix

(In [10093]) implement double_click in systray. see #2932

  Changed 4 months ago by js

  • status changed from reopened to closed
  • resolution set to fixed

Having double click and middle click open the event is consistent with everything, I guess. I'm perfectly fine with this → closed.

  Changed 4 months ago by js

  • status changed from closed to reopened
  • resolution fixed deleted

Oh, wait, we should only delay it _IF_ there are events! *reopen*

  Changed 4 months ago by asterix

  • status changed from reopened to closed
  • resolution set to fixed

(In [10099]) don't delay click on systray if there is no waiting event. Fixes #2932

Add/Change #2932 (click behavior is inconsistent between roster and tray icon)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.