Ticket #2906 (closed defect: fixed)

Opened 20 months ago

Last modified 12 months ago

nickname colors are sometimes wrong

Reported by: Jim++ Owned by: asterix
Priority: normal Milestone: 0.11.2
Component: chat Version: svn
Severity: normal Keywords:
Cc: Gustavo, Carneiro, <gjc@…> OS: All

Description

example : I choose "red" in prefs, it's orange in textview.

Attachments

Change History

Changed 20 months ago by Jim++

  • milestone 0.11.1 deleted

It's a gtk bug, GdkColor? object colors are bad if in color selector you don't click in the the "Color Name" entry but only use gui on the left.

Does anyone with a recent version can reproduce ? 2.8.20 here.

To be closed as invalid when we know if it has to be reported upstream.

Changed 20 months ago by bchomel@…

Just a comment to give you my version of gajim. I use the svn version (with debian package) on a debian sid. I have GTK+ : 2.8.20 and PyGTK : 2.8.6 I you want more information, you can contact me: xmpp:nanard51@jabber-fr.net good luck ;)

Changed 20 months ago by asterix

same behaviour with GTK2.10.4 and pygtk2.10.3

Changed 19 months ago by Jim++

  • cc Gustavo, Carneiro, <gjc@…> added

I have pygtk 2.8.6 too. I think it comes from here.

The account I created on pygtk bugzilla won't let me login for some reason so I notice Gustavo here.

Could you have a look Gustavo ?

Code about that problem is in config.py->on_preference_widget_color_set(), config.py->on_incoming_msg_colorbutton_color_set() and data/glade/preferences_window.glade

In on_preference_widget_color_set() we do widget.get_color() (colorbutton widget). The button itself shows a good color but GdkColor? object contain a bad color.

Changed 19 months ago by Jim++

We need to send a second message for mail notif ?

Gustavo ?

Changed 19 months ago by Gustavo Carneiro <gjc@…>

Try to reproduce it with a small test program. I wasn't able to reproduce with this one:

import gobject
import gtk

w = gtk.Window()
bt = gtk.ColorButton()
w.add(bt)
w.show_all()
w.connect("destroy", lambda w: gtk.main_quit())

def print_color(bt):
    color = bt.get_color()
    print color.red, color.green, color.blue
    return True

gobject.timeout_add(1000, print_color, bt)

gtk.main()

Changed 19 months ago by asterix

I am able to repro with this test program. I click the button. Then I select a color on the left part only without touching anything else (red=4, green=0 blue=0). then press OK. I see in console: 913 0 0

then I re-open the dialog, I click in the color name entry and then press ok again. I see in console: 1028 0 0

Changed 15 months ago by roidelapluie

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [8292]) Use another function to get color string. Fix #2906.

Changed 15 months ago by roidelapluie

  • os set to All

Changed 12 months ago by roidelapluie

(In [8615]) Use another function to get color string. Fix #2906.

Changed 12 months ago by roidelapluie

  • milestone changed from 0.12 to 0.11.2

Changed 12 months ago by roidelapluie

Add/Change #2906 (nickname colors are sometimes wrong)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.