Ticket #2644 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

HTML URLs are not enabled

Reported by: kiddo Owned by: asterix
Priority: normal Milestone: 0.11
Component: dialogs Version: svn
Severity: normal Keywords:
Cc: OS:

Description

See attached files: most of my contacts don't run gajim and send me URLs that are not "enabled" by gajim (can't click on them). I was told this was because they are HTML urls (based on what we saw in the sample XML outputs), and can be security risks. For example, someone could do <a href="http://www.microsoft.com">www.gajim.org</a>.

I think it would be better to work around the problem than penalize users that receive html messages (I don't really think Gaim, Pandion, etc will fix their code before the next century).

Here are some possible solutions I thought out:

Slashdot-style: display the "real" URL besides the text

Replacement: replace the URL text by the real URL

Warning: when the user clicks the URL, *IF the real URL and the shown text do not match*, show a dialog warning him/her that the URL might be an attempt to lure him/her, and show the "real" URL. "We cannot be held responsible if suddenly thousands of catgirls fall on you from the sky".

In any case: copy-pasting URLs into a browser manually really sucks, especially since gajim selects the text that follows (and people often paste URLs then add comments 5 seconds later)

Attachments

sample2.xml (1.2 kB) - added by kiddo 2 years ago.
sample1.xml (1.9 kB) - added by kiddo 2 years ago.
sample3.png (165.4 kB) - added by kiddo 2 years ago.
2644.patch (0.6 kB) - added by kiddo 2 years ago.
a homemade patch that fixes the problem for URLs coming from gaim, what do you think?

Change History

Changed 2 years ago by kiddo

Changed 2 years ago by kiddo

Changed 2 years ago by kiddo

Changed 2 years ago by nk

I vote for Slashdot-style: display the "real" URL besides the text

Changed 2 years ago by patrys

But only if it differs from the actual link text.

Changed 2 years ago by kiddo

uh.. ping? (still running gajim SVN, this thing is annoying me daily). I tried grepping the code for "url", I guess it must be in conversation_textview.py, but I don't understand the stuff in there.

Changed 2 years ago by kiddo

a homemade patch that fixes the problem for URLs coming from gaim, what do you think?

Changed 2 years ago by asterix

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.11

(In [7567]) [kiddo] fix wrong gaim xhtml HREF tag. fixes #2644

Add/Change #2644 (HTML URLs are not enabled)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.