New feature: font button for the roster font in the preferences window

[elrodeo]

This patch adds a new font button to the preference window and allows you to change the roster font. This could be useful if you want to make your roster list smaller.

[nk]

(In [7334]) [elrodeo] font button for roster font in prefs window. see #2633

[nk]

I set Sans Italic or Sans Bold and that does not work. Everything else works. I commited, I wait for reply/fix on this though.

Thanks!

[baze]

please add a "use system default" checkbox like there is for the chat font.

[jim++]

Wait ! What's the use of that ? In theme configuration we can change account lines, group lines and contact lines fonts/size. So it's an useless and confusing duplicate configuration option.

No ?

[elrodeo]

Replying to jim++:

Wait ! What's the use of that ? In theme configuration we can change account lines, group lines and contact lines fonts/size. So it's an useless and confusing duplicate configuration option. No ?

Replying to jim++:

Wait ! What's the use of that ? In theme configuration we can change account lines, group lines and contact lines fonts/size. So it's an useless and confusing duplicate configuration option. No ?

You are perfectly right. In fact, I've tried to switch the themes, but the changes have affected only the color scheme, I was sure that the extended theme configuration is only for colors. But! I have even seen the theme configuration dialog and have not noted, that there are possibilities to change the font. May be It would make sense to restructure these options, such that the configuration becomes more intuitive? By the way, the translation to Russian (I have Russian local and therefore, my gajim interface is in Russian too) for the label "Font" in this dialog is WRONG: translated to english it would be "Font color" instead of "Font". Whereas the correct label is called "Text color" and appears beside it. Screenshot is attached. May be this also was one of the reasons why I have passed this configuration possibility.

I'm very sorry for all the confusions! My patch can be removed.

[jim++]

"May be It would make sense to restructure these options, such that the configuration becomes more intuitive?" >> Any idea ?

Can you patch us for the translation problem ?

Waiting for nk comment about that.

[elrodeo]

Replying to jim++:

"May be It would make sense to restructure these options, such that the configuration becomes more intuitive?" >> Any idea ?

Well, I don't see any reason why the interface preferences are hidden behind a button. I would make an additional tab instead or use the empty space on the first tab. The existing color presets are in my opinion absolutely unnecessary.

Can you patch us for the translation problem ?

Of course. I have found several mistakes and typos in the translation. See the attached patch.

[elrodeo]

patch for the ru.po translation file

[jim++]

jim@gni:~/gajim/gajim-propre-svn/po$ patch  < /home/jim/gajim/patchs/ru.po.patch
patching file ru.po
Hunk #1 succeeded at 2463 with fuzz 2 (offset 2327 lines).
Hunk #2 succeeded at 2644 with fuzz 2 (offset 2357 lines).
Hunk #3 succeeded at 2902 with fuzz 2 (offset 2378 lines).
Hunk #4 succeeded at 3163 with fuzz 2 (offset 2429 lines).
Hunk #5 FAILED at 3177.
Hunk #6 succeeded at 3894 with fuzz 2 (offset 2719 lines).
Hunk #7 succeeded at 3921 with fuzz 1 (offset 2722 lines).
Hunk #8 succeeded at 4126 with fuzz 2 (offset 2778 lines).
Hunk #9 FAILED at 4171.
Hunk #10 FAILED at 4183.
Hunk #11 FAILED at 4191.
Hunk #12 FAILED at 4265.
Hunk #13 FAILED at 4274.
Hunk #14 succeeded at 4306 (offset 2581 lines).
Hunk #15 FAILED at 4823.
Hunk #16 FAILED at 4837.
Hunk #17 FAILED at 5650.
Hunk #18 FAILED at 5867.
Hunk #19 FAILED at 6478.
11 out of 19 hunks FAILED -- saving rejects to file ru.po.rej

[jim++]

Ah, it's against 0.10.1 of course, not svn... damn... :/

[nk]

about the russian. someone should see the DIFF and manually see if latest svn ru po needs those fixes.

OOOPS, jim is right we have this functionality (eventhough hidden and splitted in account, group, contact) already. Unless we have a from separate dialog, move under prefs dialog in first tab, patch I propose we revert the commit I did [my bad].

Also account, group, contact strings should be postfixed with row word. so Account row, Group row, Contact row

[jim++]

(In [7348]) Better strings (See #2633)

[jim++]

Reverted and changed string to +row in [7347] and [7348].

nk> "Unless we have a from separate dialog, move under prefs dialog in first tab" Err what ? Sorry ?

[elrodeo]

Replying to nk:

about the russian. someone should see the DIFF and manually see if latest svn ru po needs those fixes.

See the attached file -- this is a patch for the svn-version of ru.po.

[asterix]

is it really a good idea to move dialog in preference dialog directly ? I don't think so, this will bloat this window with a lot of widget, but we use them only once to configure a theme, then we don't want to see them anymore

[elrodeo]

we use them only once to configure a theme, then we don't want to see them anymore

You're right, but, actually, this holds for any option. So, may be it would make sense, if the predefined themes also differ by fonts from each other and not only by colors? Such that the user sees, that a `theme' is not only a color theme (like I thought).

Anyway, I think it deserves to be discussed only if many people would have the same problem. And till now only me and nk didn't got it :-).

[asterix]

a tooltip on "Theme" word ? or on manage button ?

[jim++]

I think this dialog is fine where it is.

[nk]

we need to say on manage button area that here you can cofigure colors and fonts

[asterix]

(In [7381]) add a tooltip to manage theme button. fixes #2633