Group chat notification sounds not working

[NOSPAMgilesp(a)u_washington_edu]

Couldn't get sound notifications on group chat message receipt, though I put some effort into doing so in Preferences / Advanced Config Editor. Did some debugging to see what was going on. Found this in groupchat_control.py (in the highlighting_for_message method):

                # Do we play a sound on every muc message?
                if gajim.config.get_per('soundevents', 'muc_message_received', 'enabled'):
                        if gajim.config.get('notify_on_all_muc_messages'):
                                sound = 'received'

Looked in advanced config editor, found "notify_on_all_muc_messages" which is set to false. This config value doesn't seem to be exposed through the Preferences interface (at least I couldn't find it :P), so setting a sound alert for Group Chat Message Received in the Events tab doesn't do anything. I suggest either removing the check of notify_on_all_muc_messages, or exposing that property in Preferences.

[jim++]

Yeah that's a strange behaviour. I vote for removing the check and disable

the sound by default, if it's not already the case.

[asterix]

I vote the same :)

[asterix]

(In [7dc7124d86a44d86fad2df46cb864b7c30d3e259]) use 'muc_message_received' sound if it is enable without checking notify_on_all_muc_messages option. Fixes #2494