Ticket #2467 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 months ago

Alert when quitting while transferring file

Reported by: jim++ Owned by: asterix
Priority: normal Milestone: 0.14
Component: None Version:
Severity: normal Keywords: FT
Cc: Blocked By:
OS: All Blocking:

Description

When quitting, if we are sending or receiving a file, we should alert user. Like "unread messages" dialog. I think it's not necessary when just disconnecting, but not sure.

Attachments

unfinish_transfers_dialog.patch (2.0 KB) - added by zimio 2 months ago.

Change History

Changed 6 months ago by asterix

  • type changed from defect to enhancement
  • os set to All

Changed 2 months ago by zimio

Changed 2 months ago by zimio

I wrote a patch for it.

Changed 2 months ago by asterix

Thanks for the patch, I changed it a bit so that unread message are still checked, even if we accept stopping FT.

And I removed your gajim.files_props variable, which is not needed.

Changed 2 months ago by Yann Leboulanger <asterix@…>

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.14

(In [edbeb4d0c5c6]) [zimio and I] warn user when quitting while file transfers are running. Fixes #2467

Changed 2 months ago by zimio

Because from common.protocol.bytestream import (is_transfer_active) is no longer in roster_window.py it gives this error: NameError?: global name 'is_transfer_active' is not defined

Changed 2 months ago by asterix

Oups, thanks

Changed 2 months ago by Yann Leboulanger <asterix@…>

(In [b3a57d51994c]) fix missing import. Fixes #2467

Add/Change #2467 (Alert when quitting while transferring file)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
Next status will be 'needinfo'
 
Note: See TracTickets for help on using tickets.