Ticket #2400 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Gajim does not use nickname available in vcard (ICQ, MSN transports)

Reported by: sven.burmeister@… Owned by: asterix
Priority: normal Milestone: 0.11
Component: None Version: svn
Severity: normal Keywords:
Cc: OS:

Description

If I check the information available for the transport-contacts in my contactlist I can see their nickname. However, this is not applied to the contact list which still shows the ICQ-number, MSN-ID respectively.

Expected behavior would be to use the nickname, if available.

Attachments

PyMSNt_JEP172.patch (0.7 kB) - added by asterix 2 years ago.
NON-OFFICIAL PyMSNt patch tu support JEP172 when we get contact list from server.

Change History

Changed 2 years ago by jim++

  • version set to svn

See also #2055.

But Sven is using recent svn.

Changed 2 years ago by nk

a good question is does the transport you use support JEP 172?

f.e. msn at jabber.no doesn't support it, Stian nows run stable PyMSNt

Changed 2 years ago by nk

oops. apparently I asked Stian to confirm and he said he runs 0.11.2-dev

and last time I tried I didn't get the nicknames. this means either they don't do the JEP or we have a bug.

[02:08:54 PM] stian.barmen: svn rev 226 [02:09:10 PM] stian.barmen: no changes on svn in about 2 weeks, he is freezing I think

Changed 2 years ago by asterix

  • status changed from new to closed

PyMSNt and PyICQt don't support JEP172, I attached a patch to PyICQ bug

tracker to support it. And with, Gajim get nicks nicely.

Changed 2 years ago by nk

great work Yann! :)

Changed 2 years ago by anonymous

Is there any chance to get a patch for the PyMSNt posted somewhere?

Thanks.

Changed 2 years ago by anonymous

here is the one I did, but not sure it works, and it's not official !

Changed 2 years ago by asterix

it was me

Changed 2 years ago by asterix

NON-OFFICIAL PyMSNt patch tu support JEP172 when we get contact list from server.

Changed 2 years ago by anonymous

  • status changed from closed to reopened

<presence xmlns='jabber:client' to='Me/Gajim'

from='<...>%hotmail.com@<...>/msn'> <x xmlns='vcard-temp:x:update'> <photo>37e8e3db1c10ce5628a53aa8f042ca6daab0cc54</photo> <nickname>Nickname</nickname> </x> <x xmlns='jabber:x:avatar'> <hash>37e8e3db1c10ce5628a53aa8f042ca6daab0cc54</hash> </x> <c xmlns='http://jabber.org/protocol/caps' node='http://msn- transport.jabberstudio.org/protocol/caps' ver='0.11.2-dev'/> </presence>

Nickname field is correctly sent by the transport. However gajim does not update contact name with the nickname field. Is it a bug or a feature ?

Changed 2 years ago by asterix

  • status changed from reopened to closed

your transport doesn't support JEP 172, JEP 172 talk about a <nick>

element, not about a <nickname> one. once again try with msn.gajim.org

Changed 2 years ago by anonymous

Ok from the specs I can read:

A nickname of this form has the same semantic meaning as the following data fields:

  • The "NICKNAME" field specified in vcard-temp [6].

Why not taking into account the NICKNAME field of the vcard and use it instead of requiring every transport to support JEP 172 ? IMHO that insert even more bloatness in the code. Then update infos when vcard-temp update is used (photo, nickname)

Would you accept a patch which supports that ?

Changed 2 years ago by asterix

r reasons for mnot doing that:

this require to ask vcard of every contact, and when we get them, change the name of the contact. So you'll see the nick printed in roster change, not very good

and other pb: we don't know when the contact change his nickname. We don't get any event when vcard is updated (except for avatar)

and Jabber philosophy is: you choose the nickname for your contacts. What you want is: you see the nickname your contacts wants to show you. This is MSN philosophy, not jabber one.

Changed 2 years ago by anonymous

I see the point.

It seems that when connection is done, I receive vcard-temp:update for all my online contacts. I also receive update when contact change nickname, so I don't really get the point :/

I agree to last point, though I would think that if jabber tries to transport MSN it should adapt his philosophy to the transported one.

Changed 2 years ago by asterix

I Agree we get vcard-temp:x:update when contact change his avatar, but not

his nickname. At least it's not defined in any JEP AFAIK. JEP153 define vcard-temp:x:update for avatar changement, but that's all

Changed 2 years ago by anonymous

BTW: I tried the patch with PyMSNt SVN and for me it does not work. :( I

deleted the transport and re-registred. Which version are you using it with?

Changed 2 years ago by asterix

that's totally possible, I don't know enough PyMSNt, but it seems name var

is not set, I don't know why.

Changed 2 years ago by nk

who says Jabber philosophy is you choose your own nickname for contacts?

we should find a way to have both (our nick, and their desired nick) visible. in another ticket I proposed:

use contact's nickname, and update it always, unless we somewhere defined a custom nickname, in which case show contact's nickname in info window and in tooltip.

how about that?

Changed 2 years ago by asterix

once again: we do not know when out contacts change their nick in vcard !

and we won't fetch vcard every X minutes for sure, too ugly

Changed 2 years ago by asterix

Replying to nk:

> who says Jabber philosophy is you choose your own nickname for contacts? >

I do, there is a name field in roster, we set it, not our contacts, and as I just said, there is no wayt in jabber to tell all your contacts you changed your nick, jabber is not designed for that (except maybe with pubsub, but it's not for transports for sure)

Add/Change #2400 (Gajim does not use nickname available in vcard (ICQ, MSN transports))

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.