Ticket #2072 (closed defect: fixed)

Opened 2 years ago

Last modified 14 months ago

single-click in roaster window if GNOME is set to use single click

Reported by: nekohayo@… Owned by: asterix
Priority: normal Milestone: 0.12
Component: roster Version: svn
Severity: normal Keywords: discussed
Cc: geobert@… OS: All

Description

There is a setting in GNOME that makes applications such as nautilus use single-clicking. Some other software (such as gthumb) now follow this setting, and, for the sake of consistency (I find single-click very grand-mother-friendly), I would like gajim to check for that setting in GNOME (and maybe in windows too, after all), and allow opening a conversation window by single clicking a buddy in the roaster window. This could also apply in "chat rooms" (conferences), when you left-single-click someone in the user list.

When hovering over an item, you can make it "selected" or not, that's up to you guys. I know nautilus doesn't do that, hopefully, because in nautilus you can select more than one item at a time, but in gajim you cannot, so I don't actually care if the contact automatically gets selected when the mouse hovers over it. It is, however, an interesting visual cue, but it may take more CPU juice.

You can determine this setting in gconf with this key: /apps/nautilus/preferences/click_policy

The value can be "single" or "double".

Attachments

gajim-singleclick.patch (6.0 kB) - added by TheCurse 20 months ago.
gajim-singleclick.patch

Change History

  Changed 2 years ago by nk

this sounds nice. I would love to see GTK caring about it though. it's

more a widget library feature request than an application. Unless you plan to request this from every program you use. ;)

Please ask for it (if not already asked) in bugs.gnome.org under the GTK module. Just copy paste your magnificent explanation. Adding that you want this gconf setting if user is under GNOME environment to be taken into account on treeviews (those are the widgets that we list contacts or room occupants).

About one click being grandma friendly, I TOTALLY agree with you. I didn't know nautilus had this feature on, but it's nice to see it i them. I know they are also an app, but they are more like a filemanager. On the other hand I could be wrong, as I don't remember if in MS Windows if you set one click, all applications work with one click? If not, then it's our work to do.

  Changed 2 years ago by anonymous

Hi, are you sure this should be filed in GTK? For example, I am

developping an application called Specto, which displays the websites (and other watches) in a list view (well, a treeview basically). The thing is that double-clicking an item will open the webpage (or any associated action), but single-clicking displays its properties in a vertical pane. There is no contextual menu.

How will applications like this (I'm sure I'm not the only one doing this?) will work then?

P.s.: if you still think I should file it in GTK, will this be somewhat hacked in gajim so that I don't have to wait 2 years for the next gtk release that has the feature? Oh, and glad you found my bug ticket interesting to read :)

  Changed 2 years ago by asterix

  • milestone set to 0.11

you could do hover = select row

but yes we'll implement that in gajim before 2 years (hopefully :) )

  Changed 2 years ago by asterix

someone knows how to get the value of this option ? with gconf ?

  Changed 2 years ago by nk

  • milestone set to 0.11 =>

  Changed 2 years ago by asterix

Comment (by dkirov):

with gconf key: /apps/nautilus/preferences/click_policy value is one of ('single', 'double')

  Changed 2 years ago by nk

Specto, will suffer. I remember Windows ME used to have this one click thing. I guess it failed as I've never seen it before. it's a matter of taste of ONE click should open chat or DOUBLE CLICK. but it's true it's more common to OPEN sth to do double click.

I don't think it's nice to use GCONF to determine this. Either use ONE CLICK to open, or DOUBLE click and use that all over.

because we can't use one click (we might wanna select the contact, and then hit F2 to rename [ok we can also right click -> rename)] I think this ticket should be WONTFIX or someone brave should make open chat ONE CLICK action.

  Changed 20 months ago by TheCurse

I think it should be handled like in nautilus e.g. In nautilus you can also select a file and hit F2 to rename it, but if single click open is activated in gconf it opens the file on single click (you can still select it using one of the side buttons of the mouse if you have those).

I think I have read somewhere that gnome applications should support this and that this is not something to be filed in the gnome bugtrack.

I would love gajim to support this. Is someone working on this? Otherwise I could have a look at it.

Changed 20 months ago by TheCurse

gajim-singleclick.patch

  Changed 20 months ago by anonymous

  • status changed from new to closed
  • version changed from 0.10.1 to svn
  • resolution set to worksforme

Added a patch against current head. It does not use gconf, because I do not know where in gajim it is best to check if it is set, so I just used a gajim config option. Maybe the config option could be on by default and then check against gconf. Then one could easily disable the behaviour. If someone wants to implement a gconf check it can be easily done by something like

import gconf
client = gconf.client_get_default()
click_policy = client.get_string('/apps/nautilus/preferences/click_policy')

if click_policy == 'single':

follow-up: ↓ 11   Changed 20 months ago by anonymous

  • status changed from closed to reopened
  • resolution worksforme deleted

in reply to: ↑ 10   Changed 20 months ago by TheCurse

Sorry, was not logged in, the patch is from me

  Changed 20 months ago by asterix

  • status changed from reopened to closed
  • resolution set to fixed
  • milestone set to 0.12

(In [8112]) [TheCurse?] single-clicking ability. fixes #2072

  Changed 20 months ago by asterix

I made it use gconf instead of a gajim option

  Changed 19 months ago by jim++

(In [8154]) Do not use single click for roster and gc-roster to open chats if an usefull modifier key is pressed. See #2072.

  Changed 17 months ago by roidelapluie

  • os set to All

unusable to do metacontacts and other like stuffs.

should it be reverted??

  Changed 17 months ago by roidelapluie

  • status changed from closed to reopened
  • resolution fixed deleted

  Changed 17 months ago by anonymous

couldn't metacontacts simply have a + sign (an expander button)? come on >_<

  Changed 17 months ago by roidelapluie

  • keywords discussed added

  Changed 17 months ago by Geobert

I propose the following behavior: When single clic is activated, make auto expanding the metacontact when mouse is over the contact.

With an option to configure how long the mouse should be on the contact before expanding the contact to avoid "flickyness".

  Changed 17 months ago by anonymous

  • cc geobert@… added

  Changed 15 months ago by asterix

what about that:

if we click on status icon, we expand metacontact if there is a metacontact, else we open chat window ?

BTW there is another pb, when we begin DND action, gajim opens chat window ...

  Changed 15 months ago by asterix

(In [8813]) fix DND problem when we use single click to open chat window. see #2072

  Changed 14 months ago by asterix

  • status changed from reopened to closed
  • resolution set to fixed

(In [8930]) don't open chat window when single click is enabled and we click on a metacontact icon, but expand it. fixes #2072

Add/Change #2072 (single-click in roaster window if GNOME is set to use single click)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.