Ticket #1718 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Indentation issues in /src/common/helpers.py

Reported by: multani Owned by: asterix
Priority: lowest Milestone: 0.9.1
Component: dialogs Version: 0.7
Severity: critical Keywords:
Cc: jon@… OS:

Description

Python complains about mixing of tabs and spaces in /src/common/helpers.py.

I made a _big_ patch, which simply clean up tab and space. Basically, I have converted all tab into 4 space, and fixes some identation issues at line 560 and jus after.

Ah, and I fix a typo in comment ;)

Feel free to use it or not.

Attachments

indentation.patch (32.1 kB) - added by multani 3 years ago.
Patch which fixes indentation warning

Change History

Changed 3 years ago by multani

Patch which fixes indentation warning

Changed 3 years ago by asterix

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.10

indentation is fixed, but we use tabs and not spaces :)

which comment did you fix so I can also commit it?

Changed 3 years ago by multani

Arg, i'm really tired, I saw 'spaces and not tabs', and I was _sure_ you used spaces ... (you always used tabs ?)

Anyway, the comment was on line 448, it should be (i guess) :

	        # python24 does not. if python23 if ooold we can remove this func
                                     ^^

Add/Change #1718 (Indentation issues in /src/common/helpers.py)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.