Ticket #1503 (closed defect: fixed)

Opened 3 years ago

Last modified 3 weeks ago

Keyboard shortcuts doesn't working in non-lating keyboard group.

Reported by: Vasily Chekalkin <bacek@…> Owned by: asterix
Priority: normal Milestone: 0.12
Component: None Version:
Severity: normal Keywords:
Cc: OS: All

Attachments

accel.patch (1.6 kB) - added by asterix 18 months ago.
message_window_accels.patch (5.6 kB) - added by anonymous 11 months ago.
patch against current svn
message_window_accels.2.patch (5.6 kB) - added by anonymous 11 months ago.
patch against current svn [v.02]
message_window_accels.3.patch (5.5 kB) - added by Davidov 11 months ago.
v.03 (now forwards to message textview)

Change History

Changed 3 years ago by nk

I looked all those links you said. too much blabla no solution found there.

can you name a shortcut that doesn't work for you?

Changed 2 years ago by wwolf@…

Yes,there's problem with non-latin locale, for exapmle Alt-C (compact

mode) does not working in "ru" layout.

Changed 2 years ago by nk

no fix in OOo http://qa.openoffice.org/issues/show_bug.cgi?id=42122 nor in

fox..

not sure how to fix in Gajim :$. I really think it should be Xorg to make all those transparent to dev

Changed 2 years ago by wwolf@…

Look for example Thunar (new Xfce4 file manager) there all shortcuts work

fine in any locale, and is modifiable. Or look another good file manager ROX, it also work fine in any locale.

Changed 18 months ago by davidov

I have checked Item Factory example: http://www.pygtk.org/pygtk2tutorial/sec-ItemFactoryExample.html http://www.pygtk.org/pygtk2tutorial/examples/itemfactory.py and it works perfectly in any keyboard layout.

Changed 18 months ago by davidov

Ok. Now I see. You should remove key_press_event callback. Then you should create gtk.AccelGroup?. The code looks like this:

import gtk def pass_func(accel_group, acceleratable, keyval, modifier):

print "received", keyval, modifier

w = gtk.Window() a = gtk.AccelGroup?() key, mod = gtk.accelerator_parse("<Control>W") a.connect_group(key, mod, gtk.ACCEL_VISIBLE, pass_func) w.add_accel_group(a) w.show() gtk.main()

I have tested this and it work correctly with other layouts.

Changed 18 months ago by davidov

Here is the correct code:

import gtk 
def pass_func(accel_group, acceleratable, keyval, modifier):
    print "received", keyval, modifier

w = gtk.Window()
a = gtk.AccelGroup()
key, mod = gtk.accelerator_parse("<Control>W")
a.connect_group(key, mod, gtk.ACCEL_VISIBLE, pass_func)
w.add_accel_group(a)
w.show()
 
gtk.main()

Changed 18 months ago by nk

  • milestone set to 0.12

Since you say this works okay, then we should replace our svn code with the above. Afterall most of our accels are via Glade and no need to touch those.

Changed 18 months ago by asterix

Changed 18 months ago by asterix

could you try the attached patch and tell me if it's ok for Alt+c (I did only this ons, so all other shortcuts won't work)

Changed 11 months ago by anonymous

patch against current svn

Changed 11 months ago by anonymous

patch against current svn [v.02]

Changed 11 months ago by Davidov

  • os set to All

What do you think about this patch I made? Can it be included in 11.3?

Changed 11 months ago by Davidov

v.03 (now forwards to message textview)

Changed 11 months ago by asterix

  • status changed from new to closed
  • resolution set to fixed

(In [8900]) [Davidov] use gtk.AccelGroup? to handle key press. Fixes #1503. also fixes #3466

Changed 11 months ago by Davidov

  • status changed from closed to reopened
  • resolution fixed deleted

It seems that this fixes not all shortcuts. For example control-O doesn't work in roster.

Changed 6 months ago by asterix

thst's strange for Ctrl+O, this one is handled by GTK itself.

Changed 6 months ago by Davidov

There are several shortcuts defined in chat_control.py using key press event.

Changed 3 weeks ago by asterix

does all Ctrl + l | L | v | u | Tab | PageUp? | PageDown?, Alt + a | m shortcuts don't work ?

Changed 3 weeks ago by asterix

  • status changed from reopened to closed
  • resolution set to fixed

(In [10240]) use accel func for all key in chat controls. Fixes #1503

Add/Change #1503 (Keyboard shortcuts doesn't working in non-lating keyboard group.)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.