Turn off sound and don't popup any windows when 'do-not-disturb'.

[nk]

windows don't popup by default, see PREFS

sound nice idea, we welcome your patch

[Jim++]

To all : Doesn't sounds/auto open/popup notifications should NEVER happend if you don't want to be disturbed ?

[nk]

windows popuping is alreayd happening so I don't underatnd that part. SEE PREFS

sound is nice idea, grep sound src/*

[Jim++]

I mean, do we want Gajim to be intrusive when in DND mode ? (this is a real question)

When I go to DND state, for example if I want to watch a movie, I don't want to be disturbed by intrusive things. If you still want to be notified while doing something you can still use away on NA mode. But maybe it's only my own use of dnd mode. What do everybody think ?

For the combobox exiting in prefs, for me it should toggle notifications away/XA/invisble only. And notifications always set to off in DND mode.

ps : By intrusive I mean : sound, popups for connections and deconnections of contacts, auto open new events.

[bb@…]

of COURSE it should not happen! I was really surprised when suddenly this little green popup appeared right in the middle of my fullscreen movie enjoyment. I figured it was some sort of a bug...

[Jim++]

And of course, the questions behind this are : If I made a patch for this, should it deal we sounds only or all I've mentioned ? Should this could be controlled by prefs or is it accepted as a normal behavior that should always happend in DND ?

[nk]

we can't afford to default to sth strange when DND without visible options!

atm we have Allow popup/notifications when I'm away/na/busy/invisible

we just have to include not playing sounds if that is checked and it should be enough

if you *really* think it's not enough, then replace with combobox:

Allow popup/notifications/sounds when I am: [ \/] with options in the combobox's menu:

Away
Away & Not Available
etc.. but it's too much}}}

[Jim++]

Here is a first version of a patch for this.

What it does :

• Remplace config option autopopupaway by donotnotifywhen.
• All disturbing things are now controled by this option : sounds, auto open new message, popup, popup on file_transfert_complete. The verification is done by the function notify.want_notify().
• In preferences, we have a combobox that permits "always notify", or do not notify when "dnd" or "away xa dnd invisible". If an advanced user wants, a custom list of status can be specified in ACE. Then a "Custom" entry is added to the combobox.

My problems / Questions :

1. I don't understand most of the things I've done in src/config.py and src/gtkgui.glade . I copied the way it's done for other options. This two parts MUST be checked/corrected.
2. Should I better copy what "notify.want_notify()" does in src/groupchat_control.py and src/roster_window.py instead of using an import notify ?
3. Should I use "donotnotifywhen" or "do_not_notify_when" (autopopupaway does't use _ but CodingStandards say to use them)
4. It could be good to rephrase the option label. But I don't find something better.
5. Should we use src/common/optparser.py to guess donotnotifywhen from autopopupaway ? If yes, in which functions can we do this, when the options is not added on a release ?

Waiting for comments :)

[Jim++]

Here is next version with do_not_notify_when instead of donotnotifywhen. And this one work, there was a copy/past problem in previous one...

[nk]

merging with #1005

[kkkkoaaa]

Keep a good job up! http://quick-adult-links.com