Changeset 9964

Timestamp:

07/19/08 22:42:03 (7 weeks ago)

Author:

bct

Message:

added option for esession autonegotiation
added option for modp groups to use in a negotiation

Location:

trunk/src

Files:

• chat_control.py (modified) (1 diff)
• common/config.py (modified) (1 diff)
• common/stanza_session.py (modified) (1 diff)

trunk/src/chat_control.py

@@ -1156 +1156 @@
                 # then try E2E
                 # XXX: Once we have fallback to disco, remove notexistant check
-                elif not e2e_is_active and \
-                gajim.capscache.is_supported(contact, NS_ESESSION) and \
-                not gajim.capscache.is_supported(contact, 'notexistant'):
+                elif not e2e_is_active and gajim.HAVE_PYCRYPTO \
+                and gajim.config.get('autonegotiate_esessions') \
+                and gajim.capscache.is_supported(contact, NS_ESESSION) \
+                and not gajim.capscache.is_supported(contact, 'notexistant'):
                         self.begin_e2e_negotiation()
 

trunk/src/common/config.py

@@ -192 +192 @@
                 'tabs_close_button': [opt_bool, True, _('Show close button in tab?')],
                 'log_encrypted_sessions': [opt_bool, True, _('When negotiating an encrypted session, should Gajim assume you want your messages to be logged?')],
-                'e2e_public_key': [opt_bool, False, _('When negotiating an encrypted session, should Gajim prefer to use public keys for identification?')],
+                'autonegotiate_esessions': [opt_bool, True, _('Should Gajim automatically start an encrypted session when possible?')],
+                'esession_modp': [opt_str, '5,14', _('A list of modp groups to use in a Diffie-Hellman, highest preference first, separated by commas. Valid groups are 1, 2, 5, 14, 15, 16, 17 and 18. Higher numbers are more secure, but take longer to calculate when you start a session.')],
                 'chat_avatar_width': [opt_int, 52],
                 'chat_avatar_height': [opt_int, 52],

trunk/src/common/stanza_session.py

@@ -484 +484 @@
                 x.addChild(node=xmpp.DataField(name='my_nonce', value=base64.b64encode(self.n_s), typ='hidden'))
 
-                modp_options = [ 5, 14, 2, 1 ]
+                modp_options = [ int(g) for g in gajim.config.get('esession_modp').split(',') ]
 
                 x.addChild(node=xmpp.DataField(name='modp', typ='list-single', options=map(lambda x: [ None, x ], modp_options)))