Changeset 9893

Timestamp:

07/07/08 00:24:19 (7 weeks ago)

Author:

jim++

Message:

Make nick completion work fine with an empty refer_to_nick_char
Make nick completion sorted case-insensitive. Fixes #4063. (was already IMO)
Restore #2975 way. Last nick that highlighted us are first. Fixes #2975.

Files:

• trunk/src/groupchat_control.py (modified) (3 diffs)

trunk/src/groupchat_control.py

@@ -1868 +1868 @@
                         gc_refer_to_nick_char = gajim.config.get('gc_refer_to_nick_char')
                         with_refer_to_nick_char = False
-                        if begin.endswith(gc_refer_to_nick_char):
+
+                        # first part of this if : works fine even if refer_to_nick_char
+                        if gc_refer_to_nick_char and begin.endswith(gc_refer_to_nick_char):
                                 with_refer_to_nick_char = True
                         if len(self.nick_hits) and self.last_key_tabs and \
@@ -1881 +1883 @@
                                 list_nick = gajim.contacts.get_nick_list(self.account,
                                                                         self.room_jid)
+                                list_nick.sort(key=unicode.lower) # case-insensitive sort
                                 if begin == '': 
                                         # empty message, show lasts nicks that highlighted us first
@@ -1889 +1892 @@
 
                                 list_nick.remove(self.nick) # Skip self
-                                list_nick.sort()
                                 for nick in list_nick:
                                         if nick.lower().startswith(begin.lower()):