Changeset 9823

Timestamp:

06/19/08 14:56:45 (6 months ago)

Author:

vardo

Message:

Added GajimPluginConfigDialog? class - dialog that plugins should use to present configuration to user.
Now, 'Configure' button is invoked only for plug-ins that have config_dialog.

Location:

branches/plugin-system

Files:

• data/glade/plugins_window.glade (modified) (3 diffs)
• plugins/acronyms_expander.py (modified) (1 diff)
• plugins/length_notifier.py (modified) (1 diff)
• plugins/roster_buttons/plugin.py (modified) (1 diff)
• src/plugins/gui.py (modified) (2 diffs)
• src/plugins/plugin.py (modified) (4 diffs)

branches/plugin-system/data/glade/plugins_window.glade

@@ -1 +1 @@
 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
 <!DOCTYPE glade-interface SYSTEM "glade-2.0.dtd">
-<!--Generated with glade3 3.4.5 on Mon Jun  9 15:22:01 2008 -->
+<!--Generated with glade3 3.4.5 on Thu Jun 19 13:11:54 2008 -->
 <glade-interface>
   <widget class="GtkWindow" id="plugins_window">
@@ -243 +243 @@
                             <property name="receives_default">True</property>
                             <property name="response_id">0</property>
+                            <signal name="clicked" handler="on_uninstall_plugin_button_clicked"/>
                             <child>
                               <widget class="GtkHBox" id="hbox11">
@@ -271 +272 @@
                             <property name="receives_default">True</property>
                             <property name="response_id">0</property>
+                            <signal name="clicked" handler="on_configure_plugin_button_clicked"/>
                             <child>
                               <widget class="GtkHBox" id="hbox12">

branches/plugin-system/plugins/acronyms_expander.py

@@ -45 +45 @@
                 
         def init(self):
+                self.config_dialog = None
+                
                 self.gui_extension_points = {
                         'chat_control_base' : (self.connect_with_chat_control_base,

branches/plugin-system/plugins/length_notifier.py

@@ -46 +46 @@
         @log_calls('LengthNotifierPlugin')
         def init(self):
+                #self.config_dialog = None
+                
                 self.gui_extension_points = {
                         'chat_control' : (self.connect_with_chat_control,

branches/plugin-system/plugins/roster_buttons/plugin.py

@@ -53 +53 @@
                 self.roster_vbox = gajim.interface.roster.xml.get_widget('roster_vbox2')
                 self.show_offline_contacts_menuitem = gajim.interface.roster.xml.get_widget('show_offline_contacts_menuitem')
+                
+                self.config_dialog = None
         
         @log_calls('RosterButtonsPlugin')

branches/plugin-system/src/plugins/gui.py

@@ -118 +118 @@
                 self.plugin_description_textview.set_property('sensitive', True)
                 self.uninstall_plugin_button.set_property('sensitive', True)
-                self.configure_plugin_button.set_property('sensitive', True)
+                if plugin.config_dialog is None:
+                        self.configure_plugin_button.set_property('sensitive', False)
+                else:
+                        self.configure_plugin_button.set_property('sensitive', True)
                 
         def _clear_installed_plugin_info(self):
@@ -165 +168 @@
         def on_close_button_clicked(self, widget):
                 self.window.destroy()
+        
+        @log_calls('PluginsWindow')
+        def on_configure_plugin_button_clicked(self, widget):
+                log.debug('widget: %s'%(widget))
+                selection = self.installed_plugins_treeview.get_selection()
+                model, iter = selection.get_selected()
+                if iter:
+                        plugin = model.get_value(iter, 0)
+                        plugin_name = model.get_value(iter, 1)
+                        is_active = model.get_value(iter, 2)
+                        
+
+                        result = plugin.config_dialog.run(self.window)
+
+                else:
+                        # No plugin selected. this should never be reached. As configure
+                        # plugin button should only my clickable when plugin is selected.
+                        # XXX: maybe throw exception here?
+                        pass
+        
+        @log_calls('PluginsWindow')
+        def on_uninstall_plugin_button_clicked(self, widget):
+                pass
+
+        
+class GajimPluginConfigDialog(gtk.Dialog):
+        
+        @log_calls('GajimPluginConfigDialog')
+        def __init__(self, plugin, **kwargs):
+                # TRANSLATORS: The window title for the generic configuration dialog of plugins
+                gtk.Dialog.__init__(self, '%s : %s'%(_('Configuration'), plugin.name), **kwargs)
+                self.plugin = plugin
+                self.add_button('gtk-close', gtk.RESPONSE_CLOSE)
+        
+                self.main = self.child
+                self.main.set_spacing(3)
+        
+                # TRANSLATORS: Short text stating which plugin a configuration dialog is for
+                label = gtk.Label(_('<b>%s Configuration</b>') % (plugin.name))
+                label.set_markup(label.get_label())
+                self.main.pack_start(label, False, False)
+                
+        @log_calls('GajimPluginConfigDialog')
+        def run(self, parent=None):
+                self.reparent(parent)
+                self.show_all()
+                result =  super(GajimPluginConfigDialog, self).run()
+                self.hide()
+                return result
+        

branches/plugin-system/src/plugins/plugin.py

@@ -28 +28 @@
 
 from plugins.helpers import log_calls
+from plugins.gui import GajimPluginConfigDialog
 
 class GajimPlugin(object):
@@ -97 +98 @@
         @log_calls('GajimPlugin')
         def __init__(self):
-                self.config = Config()
+                self.config = GajimPluginConfig()
                 '''
                 Plug-in configuration dictionary.
@@ -103 +104 @@
                 Automatically saved and loaded and plug-in (un)load.
                 
-                :type: `plugins.plugin.Config`
+                :type: `plugins.plugin.GajimPluginConfig`
                 '''
                 self.load_config()
+                self.config_dialog = GajimPluginConfigDialog(self)
                 self.init()
         
         @log_calls('GajimPlugin')
         def save_config(self):
-                pass
+                self.config.save()
         
         @log_calls('GajimPlugin')       
         def load_config(self):
-                pass
+                self.config.load()
         
         @log_calls('GajimPlugin')
         def __del__(self):
-                self._save_config()
+                self.save_config()
                 
         @log_calls('GajimPlugin')
@@ -136 +138 @@
                 pass
 
-class Config(dict):
-        pass
+class GajimPluginConfig(dict):
+        @log_calls('GajimPluginConfig')
+        def save(self):
+                pass
+        
+        @log_calls('GajimPluginConfig')
+        def load(self):
+                pass