Changeset 9821 for branches/plugin-system/src/plugins/gui.py

Timestamp:

06/18/08 22:45:22 (6 months ago)

Author:

vardo

Message:

Added new 'init' method to Plugin class that plugins can implement to make actions that need to be done only once - when plugin is added (not activated) to Gajim. In this method plugins should declare handlers for GUI extension points. This was created so that init method doesn't have to be reimplemented in specific way (create config, load config) - it is all done by init in Plugin class. If init is reimplemented, it must call Plugin init (eg. using super() ) to plugin work properly.

Example plug-ins were modified to use init() instead of init().

Added new category in configuration - 'plugins'. It only holds one option for each plugin - 'active', which determines whether plugin should be activated on startup.

Now, Gajim remembers which plugins are active on exit, and activates them on next startup.

Files:

• branches/plugin-system/src/plugins/gui.py (modified) (1 diff)

branches/plugin-system/src/plugins/gui.py

@@ -140 +140 @@
                 self.installed_plugins_model.set_sort_column_id(0, gtk.SORT_ASCENDING)
                 
-                for plugin_class in pm.plugins:
-                        self.installed_plugins_model.append([plugin_class, 
-                                                                                                 plugin_class.name, 
-                                                                                                 plugin_class._active])
+                for plugin in pm.plugins:
+                        self.installed_plugins_model.append([plugin, 
+                                                                                                 plugin.name, 
+                                                                                                 plugin.active])
                 
         @log_calls('PluginsWindow')
         def installed_plugins_toggled_cb(self, cell, path):
                 is_active = self.installed_plugins_model[path][2]
-                plugin_class = self.installed_plugins_model[path][0]
+                plugin = self.installed_plugins_model[path][0]
 
                 if is_active:
-                        gajim.plugin_manager.deactivate_plugin(plugin_class._instance)
+                        gajim.plugin_manager.deactivate_plugin(plugin)
                 else:
-                        gajim.plugin_manager.activate_plugin(plugin_class)
+                        gajim.plugin_manager.activate_plugin(plugin)
                 
                 self.installed_plugins_model[path][2] = not is_active