Changeset 9762 for branches/plugin-system/src/plugins/pluginmanager.py

Timestamp:

06/07/08 19:28:34 (6 months ago)

Author:

vardo

Message:

Added first version of 'Plugins' window. It's accessible through 'Edit/Plugins' item in roster menu. It seems that you can successfully (de)activate plug-ins through GUI now.

Added 'homepage' attribute to Plugin class.

Added (commented out) calls of pycallgraph in src/gajim.py for later use.

[xbright] Changed 'python' to 'python2.5' because code uses modules not available in previous versions of Python.

Files:

• branches/plugin-system/src/plugins/pluginmanager.py (modified) (8 diffs)

branches/plugin-system/src/plugins/pluginmanager.py

@@ -95 +95 @@
 
                 for path in gajim.PLUGINS_DIRS:
-                        self.plugins.extend(PluginManager.scan_dir_for_plugins(path))
+                        self._add_plugins(PluginManager.scan_dir_for_plugins(path))
 
                 log.debug('plugins: %s'%(self.plugins))
@@ -103 +103 @@
                 log.debug('active: %s'%(self.active_plugins))
 
+                
+        @log_calls('PluginManager')
+        def _add_plugin(self, plugin_class):
+                '''
+                :todo: what about adding plug-ins that are already added? Module reload
+                and adding class from reloaded module or ignoring adding plug-in?
+                '''
+                plugin_class._active = False
+                plugin_class._instance = None
+                self.plugins.append(plugin_class)
+        
+        @log_calls('PluginManager')
+        def _add_plugins(self, plugin_classes):
+                for plugin_class in plugin_classes:
+                        self._add_plugin(plugin_class)
+                
         @log_calls('PluginManager')
         def gui_extension_point(self, gui_extpoint_name, *args):
@@ -125 +141 @@
                         Looking closer - we only rewrite tuples here. Real check should be
                         made in method that invokes gui_extpoints handlers.
-
                 '''
 
@@ -142 +157 @@
 
         @log_calls('PluginManager')
-        def activate_plugin(self, plugin):
+        def activate_plugin(self, plugin_class):
                 '''
                 :param plugin: plugin to be activated
@@ -148 +163 @@
                 '''
                 
-                plugin_object = plugin()
+                plugin_object = plugin_class()
 
                 success = True
@@ -157 +172 @@
                 if success:
                         self.active_plugins.append(plugin_object)
+                        plugin_class._instance = plugin_object
+                        plugin_class._active = True
 
                 return success
@@ -166 +183 @@
                 for gui_extpoint_name, gui_extpoint_handlers in \
                                 plugin_object.gui_extension_points.iteritems():
-                        for gui_extension_point_args in self.gui_extension_points[gui_extpoint_name]:
-                                gui_extpoint_handlers[1](*gui_extension_point_args)
+                        if gui_extpoint_name in self.gui_extension_points:
+                                for gui_extension_point_args in self.gui_extension_points[gui_extpoint_name]:
+                                        gui_extpoint_handlers[1](*gui_extension_point_args)
                                 
                 # remove GUI extension points handlers (provided by plug-in) from
@@ -177 +195 @@
                 # removing plug-in from active plug-ins list
                 self.active_plugins.remove(plugin_object)
+                plugin_object.__class__._active = False
+                del plugin_object
                 
         def deactivate_all_plugins(self):